You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Madhuka <gi...@git.apache.org> on 2015/07/21 07:37:11 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-176: fixing nav-bar for ...
GitHub user Madhuka opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/160
ZEPPELIN-176: fixing nav-bar for mobile and tabs
Here is screen shoot of with issue and after fixing the issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Madhuka/incubator-zeppelin navbar-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 64fd7a59772e477b30aa9ac04a40691ce9131fca
Author: madhuka <ma...@gmail.com>
Date: 2015-07-20T14:32:52Z
fixing nav-bar for mobile and tabs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-176: fixing nav-bar for ...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/160#issuecomment-123987325
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-176: fixing nav-bar for ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/160#issuecomment-123584604
Could you also remove those 2 black lines?
And add margin on the left of connected
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-176: fixing nav-bar for ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/160#issuecomment-123940190
I guess this works as fix for now.
We never really worked on the mobile friendly version of zeppelin
+1 for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-176: fixing nav-bar for ...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/160#issuecomment-123821210
Here is changes and new look of zeppelin in mobile device.
@corneadoug: Both changes are done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-176: fixing nav-bar for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-176: fixing nav-bar for ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/160#issuecomment-125068566
LGTM. Thanks @Madhuka for the Fix. I'm merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---