You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/08/29 01:15:39 UTC
[jira] [Commented] (HIVE-2415) disallow partition column names when
doing replace columns
[ https://issues.apache.org/jira/browse/HIVE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092565#comment-13092565 ]
jiraposter@reviews.apache.org commented on HIVE-2415:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1672/
-----------------------------------------------------------
Review request for hive and Ning Zhang.
Summary
-------
move validation of renaming/replacing columns from runtime to parser
This addresses bug HIVE-2415.
https://issues.apache.org/jira/browse/HIVE-2415
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1162190
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1162190
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1162190
trunk/ql/src/test/queries/clientnegative/replace_columns.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/replace_columns_2.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/replace_columns_3.q PRE-CREATION
trunk/ql/src/test/results/clientnegative/altern1.q.out 1162190
trunk/ql/src/test/results/clientnegative/column_rename1.q.out 1162190
trunk/ql/src/test/results/clientnegative/column_rename2.q.out 1162190
trunk/ql/src/test/results/clientnegative/column_rename4.q.out 1162190
trunk/ql/src/test/results/clientnegative/replace_columns.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/replace_columns_2.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/replace_columns_3.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/replace_columns_4.q.out PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1162190
Diff: https://reviews.apache.org/r/1672/diff
Testing
-------
Thanks,
Yongqiang
> disallow partition column names when doing replace columns
> ----------------------------------------------------------
>
> Key: HIVE-2415
> URL: https://issues.apache.org/jira/browse/HIVE-2415
> Project: Hive
> Issue Type: Bug
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2415.1.patch
>
>
> alter table replace columns allows to add a column with the same name as partition column, which introduced inconsistency.
> We should disallow this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira