You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/11/08 16:22:33 UTC

[I] Enabling/Disabling operators by config is not working correctly in some cases [datafusion-comet]

andygrove opened a new issue, #2739:
URL: https://github.com/apache/datafusion-comet/issues/2739

   ### Describe the bug
   
   Enabling/Disabling operators by config is not working correctly in some cases and can result in runtime query failures such as https://github.com/apache/datafusion-comet/issues/2737
   
   
   
   ### Steps to reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Enabling/Disabling operators by config is not working correctly in some cases [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #2739:
URL: https://github.com/apache/datafusion-comet/issues/2739#issuecomment-3506909082

   In `CometExecRule`, there are separate checks for whether operators are enabled, and they are implemented inconsistently.
   
   Config check:
   
   ```scala
         case u: UnionExec
             if CometConf.COMET_EXEC_UNION_ENABLED.get(conf) &&
               u.children.forall(isCometNative) =>
   ```
   
   No config check:
   
   ```scala
         case w: WindowExec =>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Enabling/Disabling operators by config is not working correctly in some cases [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed issue #2739: Enabling/Disabling operators by config is not working correctly in some cases
URL: https://github.com/apache/datafusion-comet/issues/2739


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Enabling/Disabling operators by config is not working correctly in some cases [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #2739:
URL: https://github.com/apache/datafusion-comet/issues/2739#issuecomment-3542795382

   Main issue was fixed in https://github.com/apache/datafusion-comet/pull/2748 and handling of per-operator configs was unified in https://github.com/apache/datafusion-comet/pull/2768


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org