[GitHub] spark pull request: [SPARK-2947] DAGScheduler resubmit the stage i...

[witgo <gi...@git.apache.org>]

Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1877#discussion_r17302741
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1046,41 +1046,37 @@ class DAGScheduler(
     
           case FetchFailed(bmAddress, shuffleId, mapId, reduceId) =>
             val failedStage = stageIdToStage(task.stageId)
    -        val mapStage = shuffleToMapStage(shuffleId)
     
             // It is likely that we receive multiple FetchFailed for a single stage (because we have
             // multiple tasks running concurrently on different executors). In that case, it is possible
             // the fetch failure has already been handled by the scheduler.
    -        if (runningStages.contains(failedStage)) {
    +        if (runningStages.contains(failedStage) && stage.pendingTasks.contains(task)) {
    --- End diff --
    
    @rxin  Because there is no cancel running tasks in the stage. `stage.pendingTasks.contains(task)`  is necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org