You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/08/15 22:25:38 UTC

[Impala-ASF-CR] IMPALA-5316: [DOCS] Document last day() function

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7682

Change subject: IMPALA-5316: [DOCS] Document last_day() function
......................................................................

IMPALA-5316: [DOCS] Document last_day() function

Change-Id: I38c826abfa196bc1e6aecc2b98e158dc0ac76921
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 62 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/7682/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38c826abfa196bc1e6aecc2b98e158dc0ac76921
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-5316: [DOCS] Document last day() function

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5316: [DOCS] Document last_day() function
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38c826abfa196bc1e6aecc2b98e158dc0ac76921
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5316: [DOCS] Document last day() function

Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change.

Change subject: IMPALA-5316: [DOCS] Document last_day() function
......................................................................


Patch Set 1: Code-Review+1

LGTM.  Thanks!

-- 
To view, visit http://gerrit.cloudera.org:8080/7682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38c826abfa196bc1e6aecc2b98e158dc0ac76921
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5316: [DOCS] Document last day() function

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5316: [DOCS] Document last_day() function
......................................................................


IMPALA-5316: [DOCS] Document last_day() function

Change-Id: I38c826abfa196bc1e6aecc2b98e158dc0ac76921
Reviewed-on: http://gerrit.cloudera.org:8080/7682
Reviewed-by: Greg Rahn <gr...@cloudera.com>
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 62 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved
  Greg Rahn: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.cloudera.org:8080/7682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38c826abfa196bc1e6aecc2b98e158dc0ac76921
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>

[Impala-ASF-CR] IMPALA-5316: [DOCS] Document last day() function

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5316: [DOCS] Document last_day() function
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/149/

-- 
To view, visit http://gerrit.cloudera.org:8080/7682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38c826abfa196bc1e6aecc2b98e158dc0ac76921
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5316: [DOCS] Document last day() function

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5316: [DOCS] Document last_day() function
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38c826abfa196bc1e6aecc2b98e158dc0ac76921
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: No