[GitHub] [accumulo] ctubbsii opened a new pull request #2195: Improve client table exceptions

[GitBox <gi...@apache.org>]

ctubbsii opened a new pull request #2195:
URL: https://github.com/apache/accumulo/pull/2195


   Improve client-side table exception handling by providing tableNames
   from the client to avoid looking them up later to format an exception
   message.
   
   * Add TableOfflineException constructor to provide a formatted message
     without requiring a ClientContext to look up the name or id
   * Reuse code to check for TableNotFoundException, TableDeletedException,
     and TableOfflineException using convenience methods in ClientContext
   * Pass along tableName alongside tableId, in some internal client-side
     code, for use in exception messages, if needed later
   * Make check for requiring that a table not be offline explicit, rather
     than entangled with the tableId lookup in ClientContext
   * Update ConnectorImpl to proxy to ClientContext in a few cases where
     it previously wasn't, to ensure consistent behavior and argument
     validations
   * Use TableId from Thrift exception to avoid another client-side lookup
     when a fate operation throws an exception because the table is offline
   * Simplify private addSplit method by passing SplitEnv, rather than
     sending env.tableId and env.tableName as separate parameters
   * Remove some redundant tableName validations when they are already
     validated by context.getTableId
   * Simplify and inline a private updateAuthorizationsFailures method in
     TabletServerBatchWriter that was used to gather a set of
     authorizations failures whose tables were then checked for being
     deleted
   * Fix a few TableState enum comparisons from `.equals()` to `==`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii merged pull request #2195: Improve client table exceptions

[GitBox <gi...@apache.org>]

ctubbsii merged pull request #2195:
URL: https://github.com/apache/accumulo/pull/2195


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on pull request #2195: Improve client table exceptions

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #2195:
URL: https://github.com/apache/accumulo/pull/2195#issuecomment-877505214


   This change broke SummaryIT, because of the IllegalArgumentException getting the summary retriever now throws as a fast-failure when the table doesn't exist. I'm working on a fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on pull request #2195: Improve client table exceptions

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #2195:
URL: https://github.com/apache/accumulo/pull/2195#issuecomment-876907241


   These are some things that I noticed while working on #2183 and stood out as something that should be done first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org