[jira] Commented: (HADOOP-4583) Code optimization/cleanup in HDFS

["Suresh Srinivas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644864#action_12644864 ] 

Suresh Srinivas commented on HADOOP-4583:
-----------------------------------------

Thanks Nicholas for pointing out, GenerationStamp cannot be reused. But the Block object can be reused.

> Code optimization/cleanup in HDFS
> ---------------------------------
>
>                 Key: HADOOP-4583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4583
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.20.0
>
>
> Some of the changes needed:
> - FSNameSystem.allocateBlock creates a lot of object unnecessarily to find a blockID that is unused. It should reuse the Block object created by changing the blockID and reusing the GenerationStamp.
> - InodeFile.addBlock should use System.arrayCopy instead of copying 1 at a time.
> - Some of the for loops in FSEditLog.java can be optimized. Instead of getting the edit stream length in termination condition, a local variable should be used to do the same.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.