[GitHub] [accumulo] dlmarion commented on a change in pull request #2563: Improve log message for Merges

[GitBox <gi...@apache.org>]

dlmarion commented on a change in pull request #2563:
URL: https://github.com/apache/accumulo/pull/2563#discussion_r824098805



##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/FateServiceHandler.java
##########
@@ -421,9 +421,17 @@ public void executeFateOperation(TInfo tinfo, TCredentials c, long opid, FateOpe
         if (!canMerge)
           throw new ThriftSecurityException(c.getPrincipal(), SecurityErrorCode.PERMISSION_DENIED);
 
-        Manager.log.debug("Creating merge op: {} {} {}", tableId, startRow, endRow);
-        goalMessage += "Merge table " + tableName + "(" + tableId + ") splits from " + startRow
-            + " to " + endRow;
+        String startRowStr = startRow.toString();

Review comment:
       Take a look at `StringUtils.defaultIfBlank()`. This would end up looking like:
   ```
   String startRowStr = StringUtils.defaultIfBlank(startRow.toString(), "-inf");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org