You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/12/23 12:09:11 UTC
[GitHub] [age] fatimafatimaprogrammer opened a new pull request, #410: Changing function Signatures of age_rtrim,ltrim,trim from STABLE to IMMUTABLE
fatimafatimaprogrammer opened a new pull request, #410:
URL: https://github.com/apache/age/pull/410
### **age_ltrim [age left trim function]:**
eliminates left leading and trailing spaces on string should be immutable because this function cannot modify the database and is guaranteed to return the same results given the same arguments forever. This immutable category allows the optimizer to pre-evaluate the function when a query calls it with constant arguments.
### **age_rtrim [age right trim function]:**
eliminates right leading and trailing spaces on string should be immutable because this function cannot modify the database and is guaranteed to return the same results given the same arguments forever. This immutable category allows the optimizer to pre-evaluate the function when a query calls it with constant arguments.
### **age_trim [age trim function]:**
eliminates right leading and trailing spaces on string should be immutable because this function cannot modify the database and is guaranteed to return the same results given the same arguments forever. This immutable category allows the optimizer to pre-evaluate the function when a query calls it with constant arguments.
Generally reasons for changing signature of these functions are:
[ ] 1. These functions do not need to perform database lookup.
[ ] 2. These functions neither perform database modification.
[ ] 3. These functions are guaranteed to return the same constant results given the same arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] JoshInnis merged pull request #410: Changed volatility category of age_rtrim,age_ltrim,age_trim
Posted by GitBox <gi...@apache.org>.
JoshInnis merged PR #410:
URL: https://github.com/apache/age/pull/410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #410: Changing function Signatures of age_rtrim,ltrim,trim from STABLE to IMMUTABLE
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #410:
URL: https://github.com/apache/age/pull/410#issuecomment-1364179921
Please fix your commit log entry for the PR to be descriptive of the change. Simply stating "immutable" isn't enough. Once this is corrected, let us know so that we can review the PR for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] fatimafatimaprogrammer commented on pull request #410: Changed volatility category of age_rtrim,age_ltrim,age_trim
Posted by GitBox <gi...@apache.org>.
fatimafatimaprogrammer commented on PR #410:
URL: https://github.com/apache/age/pull/410#issuecomment-1364514281
> @fatimafatimaprogrammer Please fix your commit log entry for the PR to be descriptive of the change - what the change is and why. Simply stating "immutable" isn't enough. Once this is corrected, let us know so that we can review the PR for merging.
I've Updated PR description in a new commit let me know if it needs any further changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org