You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/06/28 00:00:06 UTC
Review Request 49288: HIVE-11402 HS2 - disallow parallel query
execution within a single Session
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49288/
-----------------------------------------------------------
Review request for hive and Thejas Nair.
Repository: hive-git
Description
-------
.
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8a4ab19
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7341635
Diff: https://reviews.apache.org/r/49288/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 49288: HIVE-11402 HS2 - disallow parallel query
execution within a single Session
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49288/#review139731
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2150)
<https://reviews.apache.org/r/49288/#comment205069>
Why is the default value false? Existing behaviour should be the default.
- Rajat Khandelwal
On June 28, 2016, 6:12 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49288/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 6:12 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8a4ab19
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java d58a913
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7341635
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java f7b3412
>
> Diff: https://reviews.apache.org/r/49288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 49288: HIVE-11402 HS2 - disallow parallel query
execution within a single Session
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49288/#review142125
-----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java (line 332)
<https://reviews.apache.org/r/49288/#comment207629>
can you also add a comment about what it is testing
service/src/java/org/apache/hive/service/cli/operation/Operation.java (line 303)
<https://reviews.apache.org/r/49288/#comment207631>
The background thread in SQLOperation also calls these register/unregister methods. (there is probably some scope for cleanup there, specially with the new method in hivesession)
Remove the TODO ?
- Thejas Nair
On July 13, 2016, 8:57 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49288/
> -----------------------------------------------------------
>
> (Updated July 13, 2016, 8:57 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bae1825
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java b0fa98f
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java d58a913
> service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java ff46ed8
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 021c1fe
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java e453354
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 78ff388
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7341635
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java f7b3412
>
> Diff: https://reviews.apache.org/r/49288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 49288: HIVE-11402 HS2 - disallow parallel query
execution within a single Session
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49288/
-----------------------------------------------------------
(Updated July 14, 2016, 1:01 a.m.)
Review request for hive and Thejas Nair.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bae1825
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java b0fa98f
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java d58a913
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java ff46ed8
service/src/java/org/apache/hive/service/cli/operation/Operation.java 021c1fe
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java e453354
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 78ff388
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7341635
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java f7b3412
Diff: https://reviews.apache.org/r/49288/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 49288: HIVE-11402 HS2 - disallow parallel query
execution within a single Session
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49288/
-----------------------------------------------------------
(Updated July 13, 2016, 8:57 p.m.)
Review request for hive and Thejas Nair.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bae1825
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java b0fa98f
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java d58a913
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java ff46ed8
service/src/java/org/apache/hive/service/cli/operation/Operation.java 021c1fe
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java e453354
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 78ff388
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7341635
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java f7b3412
Diff: https://reviews.apache.org/r/49288/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 49288: HIVE-11402 HS2 - disallow parallel query
execution within a single Session
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49288/#review142070
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On July 11, 2016, 8:12 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49288/
> -----------------------------------------------------------
>
> (Updated July 11, 2016, 8:12 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 283ef2e
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java d58a913
> service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java ff46ed8
> service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 44463c9
> service/src/java/org/apache/hive/service/cli/operation/Operation.java ba034ab
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 28c4553
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 78ff388
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7341635
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java f7b3412
>
> Diff: https://reviews.apache.org/r/49288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 49288: HIVE-11402 HS2 - disallow parallel query
execution within a single Session
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49288/
-----------------------------------------------------------
(Updated July 11, 2016, 8:12 p.m.)
Review request for hive and Thejas Nair.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 283ef2e
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java d58a913
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java ff46ed8
service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 44463c9
service/src/java/org/apache/hive/service/cli/operation/Operation.java ba034ab
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 28c4553
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 78ff388
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7341635
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java f7b3412
Diff: https://reviews.apache.org/r/49288/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 49288: HIVE-11402 HS2 - disallow parallel query
execution within a single Session
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49288/
-----------------------------------------------------------
(Updated June 30, 2016, 6 p.m.)
Review request for hive and Thejas Nair.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8a4ab19
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java d58a913
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7341635
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java f7b3412
Diff: https://reviews.apache.org/r/49288/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 49288: HIVE-11402 HS2 - disallow parallel query
execution within a single Session
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49288/
-----------------------------------------------------------
(Updated June 28, 2016, 12:42 a.m.)
Review request for hive and Thejas Nair.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8a4ab19
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestHiveSessionImpl.java d58a913
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7341635
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java f7b3412
Diff: https://reviews.apache.org/r/49288/diff/
Testing
-------
Thanks,
Sergey Shelukhin