You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by glaucio-melo-movile <gi...@git.apache.org> on 2015/10/06 21:47:55 UTC
[GitHub] activemq-artemis pull request: Adding jmeter-tests and instruction...
GitHub user glaucio-melo-movile opened a pull request:
https://github.com/apache/activemq-artemis/pull/186
Adding jmeter-tests and instructions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/glaucio-melo-movile/activemq-artemis jmeter-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #186
----
commit d6cd1780627af8c2e045bf917bc78e99bb74abd0
Author: Glaucio Melo <gl...@movile.com>
Date: 2015-10-06T19:36:24Z
Adding JMeter test Samples and instructions
commit 6feb0e48243c7eaa895b165e060f450a813bcd66
Author: Glaucio Melo <gl...@users.noreply.github.com>
Date: 2015-10-06T19:38:18Z
Update README.md
commit 351abffd27dc4f3332eda8f959e9f70ec14a0933
Author: Glaucio Melo <gl...@users.noreply.github.com>
Date: 2015-10-06T19:40:03Z
Update README.md
commit 3751fe85df65782d3de4582a91d06eb746f4c546
Author: Glaucio Melo <gl...@users.noreply.github.com>
Date: 2015-10-06T19:40:49Z
Update README.md
commit 76a7574642b12d9db79e5456ceb83ff26401efaf
Author: Glaucio Melo <gl...@users.noreply.github.com>
Date: 2015-10-06T19:43:02Z
Update README.md
commit 06f266cc0029e4abbb036ad1a8143c09127af0a6
Author: Glaucio Melo <gl...@users.noreply.github.com>
Date: 2015-10-06T19:45:22Z
Update README.md
commit 7698d01e8298bf54ea24cca8691b4d454278881f
Author: Glaucio Melo <gl...@users.noreply.github.com>
Date: 2015-10-06T19:46:26Z
Update README.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Adding jmeter-tests and instruction...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/pull/186#issuecomment-146000651
Would probably be worth squashing all the commits down to one as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Adding jmeter-tests and instruction...
Posted by glaucio-melo-movile <gi...@git.apache.org>.
Github user glaucio-melo-movile closed the pull request at:
https://github.com/apache/activemq-artemis/pull/186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Adding jmeter-tests and instruction...
Posted by glaucio-melo-movile <gi...@git.apache.org>.
Github user glaucio-melo-movile commented on the pull request:
https://github.com/apache/activemq-artemis/pull/186#issuecomment-146034857
anyway, the updated PR - https://github.com/apache/activemq-artemis/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Adding jmeter-tests and instruction...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/186#issuecomment-146017999
Git push -f would have worked
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Adding jmeter-tests and instruction...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/186#issuecomment-145996887
I believe a better place for this would be ./examples/perf/jmeter instead of the testsuite folder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Adding jmeter-tests and instruction...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/186#issuecomment-145996955
there are failures because of the lack of license headers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Adding jmeter-tests and instruction...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/186#issuecomment-145998866
I think I will merge this under examples/perf after some tweaks to your commit if you're ok...
but can you add the ASL headers to your code? If I do that myself would be cheating :) you have to license it as apache license
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Adding jmeter-tests and instruction...
Posted by glaucio-melo-movile <gi...@git.apache.org>.
Github user glaucio-melo-movile commented on the pull request:
https://github.com/apache/activemq-artemis/pull/186#issuecomment-146011198
I did perform a squash locally and for some reason I'm not able to see it here properly pushed. I will close this PR and open another one with all your suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---