You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/30 20:19:49 UTC

[GitHub] [incubator-superset] serenajiang opened a new pull request #8325: [fix] omit datasources with null columns

serenajiang opened a new pull request #8325: [fix] omit datasources with null columns
URL: https://github.com/apache/incubator-superset/pull/8325
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Users cannot add charts because there is an error in fetching the representations of the datasources due to null `table_name` or null `id`. Should prevent these fields from being null in the future, but this might require a db migration. For now, a quick fix so that users can add charts again.
   
   ### TEST PLAN
   `charts/add` looks as expected.
   
   ### REVIEWERS
   @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org