You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/21 13:30:51 UTC

[GitHub] [spark] srowen commented on pull request #35923: [SPARK-38613][TESTS] Fix `testWritingPendingBufsIsAbortedImmediatelyDuringComplete` in `RemoteBlockPushResolverSuite`

srowen commented on pull request #35923:
URL: https://github.com/apache/spark/pull/35923#issuecomment-1073900545


   I wouldn't change everything, but change cases where we suspect that it's catching too much.
   
   The problem here is really looking for RuntimeException, not the scope. That is too broad. Is something more specific thrown that we can catch without catching other stuff?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org