You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/11/07 18:46:52 UTC
[jira] [Commented] (BOOKKEEPER-82) support journal rolling
[ https://issues.apache.org/jira/browse/BOOKKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145641#comment-13145641 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-82:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2745/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
implement journal rolling
1) remove journals whose id are less than marked journal id. since they journals' data and index has been persisted to disk.
2) replay entires started from marked position in marked journal to speed up bookie start up.
This addresses bug BOOKKEEPER-82.
http://issues.apache.org/jira/browse/BOOKKEEPER-82
Diffs
-----
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 1198776
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 1198776
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieJournalRollingTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/2745/diff
Testing
-------
Thanks,
Sijie
> support journal rolling
> -----------------------
>
> Key: BOOKKEEPER-82
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-82
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 3.4.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: bookkeeper-82.patch, bookkeeper-82.patch_v2
>
>
> now bookkeeper is writing a single journal file, so the journal file has no chance to be garbage collected and the disk space keeps growing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira