You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Thomas Friedrich <tf...@yahoo.com> on 2015/11/23 20:52:43 UTC

Review Request 40609: HIVE-10613: HCatSchemaUtils getHCatFieldSchema should include field comment

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40609/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-10613
    https://issues.apache.org/jira/browse/HIVE-10613


Repository: hive-git


Description
-------

Method to convert FieldSchema to HCatFieldSchema discarded the comment associated with a FieldSchema and just set it to null. Patch updates public method getHCatFieldSchema in HCatSchemaUtils class to pass the comment from the FieldSchema object to private methods so the comment is properly set in the returned HCatFieldSchema.


Diffs
-----

  hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/schema/HCatSchemaUtils.java 16c1604 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/data/schema/TestHCatSchemaUtils.java e80c3d2 

Diff: https://reviews.apache.org/r/40609/diff/


Testing
-------

Added new testHCatFieldSchemaConversion in TestHCatSchemaUtils to test conversion for different FieldSchema categories and tests ran successfully:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6098/testReport/org.apache.hive.hcatalog.data.schema/TestHCatSchemaUtils/testHCatFieldSchemaConversion/


Thanks,

Thomas Friedrich