You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Pei-Cheng-Yu (via GitHub)" <gi...@apache.org> on 2025/10/30 16:12:49 UTC

[PR] feat(task_instances): Add operator_name_pattern pool_pattern queue_pattern as search filter [airflow]

Pei-Cheng-Yu opened a new pull request, #57571:
URL: https://github.com/apache/airflow/pull/57571

   ## Related issues
   
   Related: #53051
   
   ## WHY
   
   according to discussion in PR #56920 
   implement the search / pattern match counterpart filers in the backend for `pool`, `queue`, `operator`
   
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(task_instances): Add operator_name_pattern pool_pattern queue_pattern as search filter [airflow]

Posted by "Pei-Cheng-Yu (via GitHub)" <gi...@apache.org>.
Pei-Cheng-Yu commented on code in PR #57571:
URL: https://github.com/apache/airflow/pull/57571#discussion_r2478885968


##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -868,6 +868,15 @@ def _transform_ti_states(states: list[str] | None) -> list[TaskInstanceState | N
         filter_param_factory(TaskInstance.queue, list[str], FilterOptionEnum.ANY_EQUAL, default_factory=list)
     ),
 ]
+QueryTIPoolPatternSearch = Annotated[
+    _SearchParam,
+    Depends(search_param_factory(TaskInstance.pool, "pool_pattern")),
+]
+
+QueryTIQueuePatternSearch = Annotated[
+    _SearchParam,
+    Depends(search_param_factory(TaskInstance.queue, "queue_pattern")),

Review Comment:
   I also renamed `queue_pattern` to `queue_name_pattern`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(task_instances): Add operator_name_pattern pool_pattern queue_pattern as search filter [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #57571:
URL: https://github.com/apache/airflow/pull/57571#discussion_r2478738187


##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -868,6 +868,15 @@ def _transform_ti_states(states: list[str] | None) -> list[TaskInstanceState | N
         filter_param_factory(TaskInstance.queue, list[str], FilterOptionEnum.ANY_EQUAL, default_factory=list)
     ),
 ]
+QueryTIPoolPatternSearch = Annotated[
+    _SearchParam,
+    Depends(search_param_factory(TaskInstance.pool, "pool_pattern")),

Review Comment:
   ```suggestion
       Depends(search_param_factory(TaskInstance.pool, "pool_name_pattern")),
   ```
   
   
   Since we have already used `pool_name_pattern` for other endpoint, would it be better to use `pool_name_pattern` instead of `pool_pattern` ?
   https://github.com/apache/airflow/blob/16c544079dab9cd5967951b4dc8076ade19f0ca8/airflow-core/src/airflow/api_fastapi/common/parameters.py#L964-L96



##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -868,6 +868,15 @@ def _transform_ti_states(states: list[str] | None) -> list[TaskInstanceState | N
         filter_param_factory(TaskInstance.queue, list[str], FilterOptionEnum.ANY_EQUAL, default_factory=list)
     ),
 ]
+QueryTIPoolPatternSearch = Annotated[
+    _SearchParam,
+    Depends(search_param_factory(TaskInstance.pool, "pool_pattern")),
+]
+
+QueryTIQueuePatternSearch = Annotated[
+    _SearchParam,
+    Depends(search_param_factory(TaskInstance.queue, "queue_pattern")),

Review Comment:
   ```suggestion
       Depends(search_param_factory(TaskInstance.queue, "queue_name_pattern")),
   ```
   
   If so, we might need to name as `queue_name_pattern` to follow the same naming convention. 



##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -868,6 +868,15 @@ def _transform_ti_states(states: list[str] | None) -> list[TaskInstanceState | N
         filter_param_factory(TaskInstance.queue, list[str], FilterOptionEnum.ANY_EQUAL, default_factory=list)
     ),
 ]
+QueryTIPoolPatternSearch = Annotated[
+    _SearchParam,
+    Depends(search_param_factory(TaskInstance.pool, "pool_pattern")),
+]
+
+QueryTIQueuePatternSearch = Annotated[
+    _SearchParam,
+    Depends(search_param_factory(TaskInstance.queue, "queue_pattern")),

Review Comment:
   ```suggestion
       Depends(search_param_factory(TaskInstance.queue, "queue_name_pattern")),
   ```
   
   If so, we might need to name it as `queue_name_pattern` to follow the same naming convention. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(task_instances): Add operator_name_pattern pool_pattern queue_pattern as search filter [airflow]

Posted by "Pei-Cheng-Yu (via GitHub)" <gi...@apache.org>.
Pei-Cheng-Yu commented on code in PR #57571:
URL: https://github.com/apache/airflow/pull/57571#discussion_r2478884326


##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -868,6 +868,15 @@ def _transform_ti_states(states: list[str] | None) -> list[TaskInstanceState | N
         filter_param_factory(TaskInstance.queue, list[str], FilterOptionEnum.ANY_EQUAL, default_factory=list)
     ),
 ]
+QueryTIPoolPatternSearch = Annotated[
+    _SearchParam,
+    Depends(search_param_factory(TaskInstance.pool, "pool_pattern")),

Review Comment:
   Thanks for reviewing!
   I’ve updated the parameter to use `pool_name_pattern`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(task_instances): Add operator_name_pattern pool_pattern queue_pattern as search filter [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #57571:
URL: https://github.com/apache/airflow/pull/57571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(task_instances): Add operator_name_pattern pool_pattern queue_pattern as search filter [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #57571:
URL: https://github.com/apache/airflow/pull/57571#issuecomment-3470990609

   > Nice to have this but "danger zone", the columns you add to be filtered is not having an index, so if this is the only part you are searching for and you have a large DB then this is triggering a full table scan and can be used as DOS as well as will have poor response time.
   
   Good point!
   We are resolving N+1 problems recently and maybe checking whether there are indexes for all the filters will be next stage of API performance optimization. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(task_instances): Add operator_name_pattern pool_pattern queue_pattern as search filter [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #57571:
URL: https://github.com/apache/airflow/pull/57571#issuecomment-3486226588

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org