You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/01/07 11:26:57 UTC

[GitHub] [hop] hansva commented on a change in pull request #1255: HOP-3605, HOP-3579

hansva commented on a change in pull request #1255:
URL: https://github.com/apache/hop/pull/1255#discussion_r780205491



##########
File path: plugins/transforms/getfilenames/src/main/java/org/apache/hop/pipeline/transforms/getfilenames/GetFileNames.java
##########
@@ -279,7 +279,7 @@ public boolean processRow() throws HopException {
         putRow(data.outputRowMeta, outputRow);
 
         if (meta.getRowLimit() > 0
-            && data.rownr >= meta.getRowLimit()) { // limit has been reached: stop now.

Review comment:
       I would have kept it like this, it's defensive programming. What if in some really odd case it does get above the limit? then it will stop with limit+1, now it will continue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org