You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/05/30 14:11:55 UTC
[Impala-ASF-CR] IMPALA-12170: Fix WebUI test failure due to the new /events page
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19953
Change subject: IMPALA-12170: Fix WebUI test failure due to the new /events page
......................................................................
IMPALA-12170: Fix WebUI test failure due to the new /events page
IMPALA-12053 makes the "/events" link visible in catalogd WebUI. This
causes test failures in test_webserver_hide_logs_link which checks all
the visible links. This patch fixes the test.
Tests:
- Ran test_webserver_hide_logs_link locally
Change-Id: I23cb45cf9bf2225a832ce77642d698709eebe604
---
M tests/custom_cluster/test_web_pages.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/19953/1
--
To view, visit http://gerrit.cloudera.org:8080/19953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23cb45cf9bf2225a832ce77642d698709eebe604
Gerrit-Change-Number: 19953
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12170: Fix WebUI test failure due to the new /events page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19953 )
Change subject: IMPALA-12170: Fix WebUI test failure due to the new /events page
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9360/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23cb45cf9bf2225a832ce77642d698709eebe604
Gerrit-Change-Number: 19953
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 01:04:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12170: Fix WebUI test failure due to the new /events page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19953 )
Change subject: IMPALA-12170: Fix WebUI test failure due to the new /events page
......................................................................
IMPALA-12170: Fix WebUI test failure due to the new /events page
IMPALA-12053 makes the "/events" link visible in catalogd WebUI. This
causes test failures in test_webserver_hide_logs_link which checks all
the visible links. This patch fixes the test.
Tests:
- Ran test_webserver_hide_logs_link locally
Change-Id: I23cb45cf9bf2225a832ce77642d698709eebe604
Reviewed-on: http://gerrit.cloudera.org:8080/19953
Reviewed-by: Andrew Sherman <as...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_web_pages.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Andrew Sherman: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I23cb45cf9bf2225a832ce77642d698709eebe604
Gerrit-Change-Number: 19953
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12170: Fix WebUI test failure due to the new /events page
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19953 )
Change subject: IMPALA-12170: Fix WebUI test failure due to the new /events page
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/19953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23cb45cf9bf2225a832ce77642d698709eebe604
Gerrit-Change-Number: 19953
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 00:39:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12170: Fix WebUI test failure due to the new /events page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19953 )
Change subject: IMPALA-12170: Fix WebUI test failure due to the new /events page
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13141/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23cb45cf9bf2225a832ce77642d698709eebe604
Gerrit-Change-Number: 19953
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 May 2023 14:34:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12170: Fix WebUI test failure due to the new /events page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19953 )
Change subject: IMPALA-12170: Fix WebUI test failure due to the new /events page
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23cb45cf9bf2225a832ce77642d698709eebe604
Gerrit-Change-Number: 19953
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 06:19:32 +0000
Gerrit-HasComments: No