You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by akashrn5 <gi...@git.apache.org> on 2017/12/04 15:09:23 UTC
[GitHub] carbondata pull request #1610: [CARBONDATA-1879]do not drop the table if the...
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1610
[CARBONDATA-1879]do not drop the table if the load, insert or insert overwrite is in progress
do not drop the table if the load, insert or insert overwrite is in progress
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [*] Any interfaces changed?
NA
- [*] Any backward compatibility impacted?
NA
- [*] Document update required?
NA
- [*] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
local testing is done
- [*] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akashrn5/incubator-carbondata drop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1610.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1610
----
commit a0e516709f6b2053845fc882c02a0ee7aee91fac
Author: akashrn5 <ak...@gmail.com>
Date: 2017-12-04T15:06:15Z
do not drop the table if the load, insert or insert overwrite is in progress
----
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r154982129
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala ---
@@ -83,6 +85,11 @@ private[sql] case class CarbonAlterTableRenameCommand(
sparkSession)
carbonTable = metastore.lookupRelation(Some(oldDatabaseName), oldTableName)(sparkSession)
.asInstanceOf[CarbonRelation].carbonTable
+ // if any load is in progress for table, do not allow rename table
+ if (SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)) {
+ throw new AnalysisException(s"alter rename failed, load, insert or insert " +
--- End diff --
Since this PR not just modify for drop table command, can you add the reject logic in all impacted command. I think all commands that involves metadata modification is not allowed, right? @ravipesala please have a look
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1610
retest sdv please
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r154979231
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/concurrent/TestLoadTableConcurrentScenario.scala ---
@@ -0,0 +1,61 @@
+package org.apache.carbondata.spark.testsuite.concurrent
--- End diff --
license header needed
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1696/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
@akashrn5 Please fix the SDV
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/488/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/506/
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r154836171
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -877,4 +877,24 @@ object CommonUtil {
}
}
+ /**
+ * This function checks if any load or insert overwrite is in progress before dropping that table
+ * @return
+ */
+ def checkLoadInProgressForTable(carbonTable: CarbonTable): Boolean = {
--- End diff --
Please move this method to SegmentStatusManager
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879]do not drop the table if the load, ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2074/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/532/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879]do not drop the table if the load, ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1688/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2121/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/433/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2178/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1738/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/473/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/477/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/536/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2168/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2083/
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop...
Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r155435306
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/concurrent/TestLoadTableConcurrentScenario.scala ---
@@ -0,0 +1,61 @@
+package org.apache.carbondata.spark.testsuite.concurrent
--- End diff --
header added
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/547/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/434/
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r154979407
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala ---
@@ -71,6 +73,10 @@ case class CarbonDropTableCommand(
ifExistsSet,
sparkSession)
OperationListenerBus.getInstance.fireEvent(dropTablePreEvent, operationContext)
+ if (SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)) {
+ throw new AnalysisException(s"Cannot drop table, load or insert overwrite is " +
--- End diff --
use operationNotAllowed
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r154979725
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala ---
@@ -83,6 +85,11 @@ private[sql] case class CarbonAlterTableRenameCommand(
sparkSession)
carbonTable = metastore.lookupRelation(Some(oldDatabaseName), oldTableName)(sparkSession)
.asInstanceOf[CarbonRelation].carbonTable
+ // if any load is in progress for table, do not allow rename table
+ if (SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)) {
+ throw new AnalysisException(s"alter rename failed, load, insert or insert " +
--- End diff --
use operationNotAllowed
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r154836484
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -877,4 +877,24 @@ object CommonUtil {
}
}
+ /**
+ * This function checks if any load or insert overwrite is in progress before dropping that table
+ * @return
+ */
+ def checkLoadInProgressForTable(carbonTable: CarbonTable): Boolean = {
+ var canDropTable = true
--- End diff --
Rename the variable name to `loadInProgress` and initialize to `false`
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2098/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2163/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1729/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2088/
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1610
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2148/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1715/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1773/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2125/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1704/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1610
@ravipesala i have added test case for both scenario
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
LGTM
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/425/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1767/
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r154836331
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ---
@@ -877,4 +877,24 @@ object CommonUtil {
}
}
+ /**
+ * This function checks if any load or insert overwrite is in progress before dropping that table
+ * @return
+ */
+ def checkLoadInProgressForTable(carbonTable: CarbonTable): Boolean = {
--- End diff --
Please change name of method to `checkIfAnyLoadInProgressForTable`
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/568/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2112/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879]do not drop the table if the load, ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/416/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/448/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2135/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1816/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
@akashrn5 Please try to add testcase.
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1703/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1790/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2087/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1610
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2099/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1804/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879]do not drop the table if the load, ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/424/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1752/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1610
retest this please
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1610
retest this please
---
[GitHub] carbondata pull request #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1610#discussion_r155258692
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala ---
@@ -83,6 +85,11 @@ private[sql] case class CarbonAlterTableRenameCommand(
sparkSession)
carbonTable = metastore.lookupRelation(Some(oldDatabaseName), oldTableName)(sparkSession)
.asInstanceOf[CarbonRelation].carbonTable
+ // if any load is in progress for table, do not allow rename table
+ if (SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)) {
+ throw new AnalysisException(s"alter rename failed, load, insert or insert " +
--- End diff --
@jackylk yes, we have identified drop, alter,and delete segment commands which are impacted, so we need to add restriction to them.
---
[GitHub] carbondata issue #1610: [CARBONDATA-1789][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/459/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1708/
---
[GitHub] carbondata issue #1610: [CARBONDATA-1879][CARBONDATA-1791]do not drop the ta...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1610
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/438/
---