You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/01/20 17:10:31 UTC
[GitHub] [qpid-dispatch] ted-ross opened a new pull request #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
ted-ross opened a new pull request #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
URL: https://github.com/apache/qpid-dispatch/pull/667
…epting them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
URL: https://github.com/apache/qpid-dispatch/pull/667#issuecomment-576372238
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=h1) Report
> Merging [#667](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/0e4c8d8bd6a66b1f0c5dab2e1c6bb19c59f2933c?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #667 +/- ##
=========================================
+ Coverage 86.83% 86.9% +0.06%
=========================================
Files 92 92
Lines 21027 21031 +4
=========================================
+ Hits 18258 18276 +18
+ Misses 2769 2755 -14
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/modules/mobile\_sync/mobile.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvbW9iaWxlX3N5bmMvbW9iaWxlLmM=) | `94.84% <100%> (+0.06%)` | :arrow_up: |
| [src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==) | `88.18% <0%> (-1.58%)` | :arrow_down: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.58% <0%> (-0.34%)` | :arrow_down: |
| [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.19%)` | :arrow_down: |
| [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `88% <0%> (-0.03%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.36% <0%> (+0.11%)` | :arrow_up: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <0%> (+0.18%)` | :arrow_up: |
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.14% <0%> (+0.24%)` | :arrow_up: |
| [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `90.22% <0%> (+0.56%)` | :arrow_up: |
| [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `80.52% <0%> (+0.58%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=footer). Last update [0e4c8d8...d9a4077](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ted-ross merged pull request #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
Posted by GitBox <gi...@apache.org>.
ted-ross merged pull request #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
URL: https://github.com/apache/qpid-dispatch/pull/667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
URL: https://github.com/apache/qpid-dispatch/pull/667#issuecomment-576372238
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=h1) Report
> Merging [#667](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/0e4c8d8bd6a66b1f0c5dab2e1c6bb19c59f2933c?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #667 +/- ##
==========================================
+ Coverage 86.83% 86.87% +0.04%
==========================================
Files 92 92
Lines 21027 21032 +5
==========================================
+ Hits 18258 18271 +13
+ Misses 2769 2761 -8
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/modules/mobile\_sync/mobile.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvbW9iaWxlX3N5bmMvbW9iaWxlLmM=) | `94.84% <100%> (+0.06%)` | :arrow_up: |
| [src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==) | `88.18% <0%> (-1.58%)` | :arrow_down: |
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.41% <0%> (-0.49%)` | :arrow_down: |
| [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.8% <0%> (-0.23%)` | :arrow_down: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.69% <0%> (-0.23%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.12% <0%> (-0.12%)` | :arrow_down: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <0%> (+0.18%)` | :arrow_up: |
| [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `90.22% <0%> (+0.56%)` | :arrow_up: |
| [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `95.17% <0%> (+0.68%)` | :arrow_up: |
| [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.57% <0%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=footer). Last update [0e4c8d8...d9a4077](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
URL: https://github.com/apache/qpid-dispatch/pull/667#discussion_r368658550
##########
File path: src/router_core/modules/mobile_sync/mobile.c
##########
@@ -51,6 +51,8 @@ static const char *HAVE_SEQ = "have_seq";
#define ADDR_SYNC_TO_BE_DELETED 0x00000004
#define ADDR_SYNC_MOBILE_TRACKING 0x00000008
+#define ADDR_SYNC_MA_REQUESTED 0x00000001
Review comment:
This leads me to believe this is a flag for Address.sync_mask - possible alias for IN_ADD_LIST. Better name and comment requested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
Posted by GitBox <gi...@apache.org>.
ted-ross commented on a change in pull request #667: DISPATCH-1551 - Assure that differential MAUs are expected before acc…
URL: https://github.com/apache/qpid-dispatch/pull/667#discussion_r368660215
##########
File path: src/router_core/modules/mobile_sync/mobile.c
##########
@@ -51,6 +51,8 @@ static const char *HAVE_SEQ = "have_seq";
#define ADDR_SYNC_TO_BE_DELETED 0x00000004
#define ADDR_SYNC_MOBILE_TRACKING 0x00000008
+#define ADDR_SYNC_MA_REQUESTED 0x00000001
Review comment:
Will fix...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org