[jira] [Updated] (CASSANDRA-20978) JVMStabilityInspector does not call LoggingSupport#onShutdown() before killing the JVM

["Caleb Rackliffe (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-20978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Caleb Rackliffe updated CASSANDRA-20978:
----------------------------------------
     Bug Category: Parent values: Code(13163)Level 1 values: Bug - Unclear Impact(13164)
       Complexity: Normal
    Discovered By: User Report
    Fix Version/s: 6.x
         Severity: Normal
           Status: Open  (was: Triage Needed)

The only possibly tricky thing here is that stopping the logging context might hang if the reason we're killing the JVM is an OOM. It might make sense to initially limit a fix to paths that run through \{{inspectCommitLogError}} and \{{handleStartupFSError}}.

> JVMStabilityInspector does not call LoggingSupport#onShutdown() before killing the JVM
> --------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-20978
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20978
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Observability/Logging
>            Reporter: Caleb Rackliffe
>            Priority: Normal
>             Fix For: 6.x
>
>
> `Killer#killCurrentJVM()` does not stop the `LoggerContext`, and this can hide error messages logged immediately prior to that. (Before we exit, we remove the drain-on-shutdown hook that otherwise would stop it.)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org