You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/08/16 20:51:38 UTC
[kudu-CR](gh-pages) Add weekly update for 8/16
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4008
Change subject: Add weekly update for 8/16
......................................................................
Add weekly update for 8/16
Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
---
A _posts/2016-08-16-weekly-update.md
1 file changed, 98 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/4008/1
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: Add weekly update for 8/16
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4008/1/_posts/2016-08-16-weekly-update.md
File _posts/2016-08-16-weekly-update.md:
PS1, Line 55: which
s/which with/with which/ ?
Line 65: ["exactly-once" semantics](https://gerrit.cloudera.org/#/c/2642/) for write operations.
Can we confirm if this is the right gerrit link for this feature ? It appeared like a subtask of main feature, I could be wrong though.
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Add weekly update for 8/16
......................................................................
Add weekly update for 8/16
Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Reviewed-on: http://gerrit.cloudera.org:8080/4008
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Todd Lipcon <to...@apache.org>
---
A _posts/2016-08-16-weekly-update.md
1 file changed, 107 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Todd Lipcon: Verified
Alexey Serbin: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add weekly update for 8/16
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Add weekly update for 8/16
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4008/1/_posts/2016-08-16-weekly-update.md
File _posts/2016-08-16-weekly-update.md:
Line 56: For example, the a new tool he has built for dumping peer identifiers from a tablet's
Typo: 'the a new tool'. Probably, it should have been 'the new tool'.
PS1, Line 57: replica
Why the italics for the 'replica' part?
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Add weekly update for 8/16
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4008/1/_posts/2016-08-16-weekly-update.md
File _posts/2016-08-16-weekly-update.md:
Line 24: ## Development discussions and code in progress
> A couple other things come to mind (since it was such a busy week):
Added the AUTO_FLUSH_BACKGROUND bit, but didn't do the bug fixes -- there's already a lot of content in this post and figured that if people want to track every bug fix they should follow the reviews mailing list directly
(in slow weeks I do write bullet points for bugs, but here we've got so much content already)
PS1, Line 55: which
> s/which with/with which/ ?
Done
Line 56: For example, the a new tool he has built for dumping peer identifiers from a tablet's
> Typo: 'the a new tool'. Probably, it should have been 'the new tool'.
Done
Line 57: consensus metadata is triggered using 'kudu tablet cmeta print_replica_uuids`.
> It's not clear in gerrit, but is it possible that the first backtick here i
Done
Line 65: ["exactly-once" semantics](https://gerrit.cloudera.org/#/c/2642/) for write operations.
> Can we confirm if this is the right gerrit link for this feature ? It appea
I linked to the design doc, since the feature itself is spread across 10-20 patches
Line 72: * Mike Percy picked back up working on garbage collection of [past versions of
> Nit: maybe "resumed" instead of "picked back up"?
Done
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Add weekly update for 8/16
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Add weekly update for 8/16
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4008/1/_posts/2016-08-16-weekly-update.md
File _posts/2016-08-16-weekly-update.md:
PS1, Line 57: replica
> Why the italics for the 'replica' part?
OK, probably it's some gerrit feature.
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Mike Percy,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4008
to look at the new patch set (#2).
Change subject: Add weekly update for 8/16
......................................................................
Add weekly update for 8/16
Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
---
A _posts/2016-08-16-weekly-update.md
1 file changed, 107 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/4008/2
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add weekly update for 8/16
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add weekly update for 8/16
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4008/1/_posts/2016-08-16-weekly-update.md
File _posts/2016-08-16-weekly-update.md:
Line 24: ## Development discussions and code in progress
A couple other things come to mind (since it was such a busy week):
- Alexey's work on AUTO_BACKGROUND_FLUSH, since it's a significant patch.
- Bruce's commit 609054c.
- Your commit af5c059. It was small but it has a pretty big effect on performance.
- Dan's outstanding commit (https://gerrit.cloudera.org/#/c/4007) for a bug found by Will.
Line 57: consensus metadata is triggered using 'kudu tablet cmeta print_replica_uuids`.
It's not clear in gerrit, but is it possible that the first backtick here is actually a single quote?
Line 72: * Mike Percy picked back up working on garbage collection of [past versions of
Nit: maybe "resumed" instead of "picked back up"?
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add weekly update for 8/16
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Add weekly update for 8/16
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa8f3cae28f3ee485c3e8d80ae03d4ebb697b99
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No