You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "Mrart (via GitHub)" <gi...@apache.org> on 2024/09/06 03:09:58 UTC
[PR] drop lockutilsTest failed [incubator-streampark]
Mrart opened a new pull request, #4036:
URL: https://github.com/apache/incubator-streampark/pull/4036
## What changes were proposed in this pull request
drop lockutilsTest failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drop lockutilsTest failed [incubator-streampark]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #4036:
URL: https://github.com/apache/incubator-streampark/pull/4036#issuecomment-2333166757
> > I have never heard of any open source project doing this. Cancelling the test if it fails is unreasonable. You should fix the problem until the test passes. I personally refuse to merge this PR.
>
> This code has not been used in the project for the time being. I tried to fix it, but there is still a problem. Let's add an issue to follow up this ut test.
You should fix the test and merge the PR. This is the case for many open source projects.
I even agree not to delete this test and merge this PR, but I don't agree to delete this test directly.
Can you describe what's wrong with this test? Why does the test fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drop lockutilsTest failed [incubator-streampark]
Posted by "Mrart (via GitHub)" <gi...@apache.org>.
Mrart commented on PR #4036:
URL: https://github.com/apache/incubator-streampark/pull/4036#issuecomment-2333163178
> I have never heard of any open source project doing this. Cancelling the test if it fails is unreasonable. You should fix the problem until the test passes. I personally refuse to merge this PR.
This code has not been used in the project for the time being. I tried to fix it, but there is still a problem. Let's add an issue to follow up this ut test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drop lockutilsTest failed [incubator-streampark]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4036:
URL: https://github.com/apache/incubator-streampark/pull/4036#issuecomment-2333148518
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4036) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4036&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=4036&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=4036&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4036&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=4036&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=4036)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drop lockutilsTest failed [incubator-streampark]
Posted by "Mrart (via GitHub)" <gi...@apache.org>.
Mrart commented on PR #4036:
URL: https://github.com/apache/incubator-streampark/pull/4036#issuecomment-2333163742
> I have never heard of any open source project doing this. Cancelling the test if it fails is unreasonable. You should fix the problem until the test passes. I personally refuse to merge this PR.
This ut test now prevents the merging of all our PRS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drop lockutilsTest failed [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #4036:
URL: https://github.com/apache/incubator-streampark/pull/4036#issuecomment-2333176830
Thanks for your contribution, but the current PR is a duplicate of this [PR](https://github.com/apache/incubator-streampark/pull/4005)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org