You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/27 16:07:59 UTC
[GitHub] [iceberg] samredai commented on a change in pull request #3383: Add black and isort as well as tox -e format command
samredai commented on a change in pull request #3383:
URL: https://github.com/apache/iceberg/pull/3383#discussion_r737628796
##########
File path: python/tests/utils/test_bin_packing.py
##########
@@ -17,34 +17,76 @@
import random
-from iceberg.utils.bin_packing import PackingIterator
import pytest
+from iceberg.utils.bin_packing import PackingIterator
+
-@pytest.mark.parametrize("splits, lookback, split_size, open_cost", [
Review comment:
The consistency is nice because individual styles in python can vary wildly. The auto sorting of imports is also super helpful since it guarantees imports to be neatly organized as stdlib, third party, and package imports, each section separated by a single space. Since we recommend auto formatters on the java side and have style checks, has that been a net positive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org