[GitHub] [helix] rahulrane50 commented on a diff in pull request #2458: Refactor testHelixViewAggregator

["rahulrane50 (via GitHub)" <gi...@apache.org>]

rahulrane50 commented on code in PR #2458:
URL: https://github.com/apache/helix/pull/2458#discussion_r1189272252


##########
helix-view-aggregator/src/test/java/org/apache/helix/view/integration/TestHelixViewAggregator.java:
##########
@@ -247,11 +274,16 @@ private void resetViewClusterConfig(int refreshPeriod, List<PropertyType> proper
     _configAccessor.setClusterConfig(viewClusterName, viewClusterConfig);
   }
 
-  private void verifyViewClusterEventChanges(boolean externalViewChange,
-      boolean instanceConfigChange, boolean liveInstancesChange) {
-    Assert.assertEquals(_monitor.getExternalViewChangeCount() > 0, externalViewChange);
-    Assert.assertEquals(_monitor.getInstanceConfigChangeCount() > 0, instanceConfigChange);
-    Assert.assertEquals(_monitor.getLiveInstanceChangeCount() > 0, liveInstancesChange);
+  private Predicate<MockViewClusterSpectator> hasExternalViewChanges() {

Review Comment:
   nit : nice use of predicate! may be we can add this method in MockViewClusterSpectator itself!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org