You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2019/02/25 23:49:26 UTC
[Impala-ASF-CR] Fix a handful of JNI usage errors.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12582
Change subject: Fix a handful of JNI usage errors.
......................................................................
Fix a handful of JNI usage errors.
Running Impala with LIB_HDFS_OPTS=-Xcheck:jni revealed a case of "FATAL
ERROR in native method: Bad global or local ref passed to JNI" as well
as 'WARNING in native method: JNI FindClass received a bad class
descriptor "Lorg/apache/impala/common/Pair;"' This commit fixes these.
There are additional JNI warnings that I'm working through
as well as a fundamental question about how to avoid these
systematically.
Kudos to Lars Volker and Sahil Takiar who co-found these issues.
Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
---
M be/src/catalog/catalog-util.cc
M be/src/util/logging-support.cc
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/12582/1
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-8250: Fix a handful of JNI usage errors.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12582 )
Change subject: IMPALA-8250: Fix a handful of JNI usage errors.
......................................................................
Patch Set 2:
Added a JIRA. Yeah; I'm still working on this, but this is the lowest-hanging fruit.
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 21:43:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix a handful of JNI usage errors.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12582 )
Change subject: Fix a handful of JNI usage errors.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2239/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 00:24:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8250: Fix a handful of JNI usage errors.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12582 )
Change subject: IMPALA-8250: Fix a handful of JNI usage errors.
......................................................................
IMPALA-8250: Fix a handful of JNI usage errors.
Running Impala with LIB_HDFS_OPTS=-Xcheck:jni revealed a case of "FATAL
ERROR in native method: Bad global or local ref passed to JNI" as well
as 'WARNING in native method: JNI FindClass received a bad class
descriptor "Lorg/apache/impala/common/Pair;"' This commit fixes these.
There are additional JNI warnings that I'm working through
as well as a fundamental question about how to avoid these
systematically.
Kudos to Lars Volker and Sahil Takiar who co-found these issues.
Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Reviewed-on: http://gerrit.cloudera.org:8080/12582
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/catalog/catalog-util.cc
M be/src/util/logging-support.cc
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-8250: Fix a handful of JNI usage errors.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12582 )
Change subject: IMPALA-8250: Fix a handful of JNI usage errors.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 04:11:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8250: Fix a handful of JNI usage errors.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12582 )
Change subject: IMPALA-8250: Fix a handful of JNI usage errors.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3838/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 00:03:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8250: Fix a handful of JNI usage errors.
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12582 )
Change subject: IMPALA-8250: Fix a handful of JNI usage errors.
......................................................................
Patch Set 2: Code-Review+2
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:40:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8250: Fix a handful of JNI usage errors.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12582 )
Change subject: IMPALA-8250: Fix a handful of JNI usage errors.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 00:03:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8250: Fix a handful of JNI usage errors.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Sahil Takiar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12582
to look at the new patch set (#2).
Change subject: IMPALA-8250: Fix a handful of JNI usage errors.
......................................................................
IMPALA-8250: Fix a handful of JNI usage errors.
Running Impala with LIB_HDFS_OPTS=-Xcheck:jni revealed a case of "FATAL
ERROR in native method: Bad global or local ref passed to JNI" as well
as 'WARNING in native method: JNI FindClass received a bad class
descriptor "Lorg/apache/impala/common/Pair;"' This commit fixes these.
There are additional JNI warnings that I'm working through
as well as a fundamental question about how to avoid these
systematically.
Kudos to Lars Volker and Sahil Takiar who co-found these issues.
Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
---
M be/src/catalog/catalog-util.cc
M be/src/util/logging-support.cc
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/12582/2
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] Fix a handful of JNI usage errors.
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12582 )
Change subject: Fix a handful of JNI usage errors.
......................................................................
Patch Set 1: Code-Review+1
LGTM. Assuming we are working on this incrementally and at some point we will want all our tests to run with -Xcheck:jni going forward?
Might be good to open a JIRA as well.
--
To view, visit http://gerrit.cloudera.org:8080/12582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3b8bccee20cc882cffa4439e550e1f48347d3a6
Gerrit-Change-Number: 12582
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 19:42:04 +0000
Gerrit-HasComments: No