You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/08/22 16:48:55 UTC
[kudu-CR] [iwyu] a minor clean-up after recent merges
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7773
Change subject: [iwyu] a minor clean-up after recent merges
......................................................................
[iwyu] a minor clean-up after recent merges
After recent updates, some file became not compliant with IWYU.
This patch fixes that to have the IWYU in the clean state since
the IWYU configuration is already enabled for gerrit pre-commit
verification.
I also sneaked in a few other updates on other files to remove them
from the 'muted' list in build-support/iwyu/iwyu-filter.awk
Change-Id: I052056efc32b5173c51cd3f0f939e19e604a7091
---
M build-support/iwyu/iwyu-filter.awk
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
M src/kudu/integration-tests/internal_mini_cluster-itest-base.h
M src/kudu/integration-tests/internal_mini_cluster.cc
M src/kudu/integration-tests/internal_mini_cluster.h
M src/kudu/integration-tests/log_verifier.cc
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/sys_catalog-test.cc
M src/kudu/rpc/connection.h
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_server_test_util.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/net/sockaddr.cc
29 files changed, 37 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/7773/1
--
To view, visit http://gerrit.cloudera.org:8080/7773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I052056efc32b5173c51cd3f0f939e19e604a7091
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [iwyu] a minor clean-up after recent merges
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [iwyu] a minor clean-up after recent merges
......................................................................
[iwyu] a minor clean-up after recent merges
After recent updates, some file became not compliant with IWYU.
This patch fixes that to have the IWYU in the clean state since
the IWYU configuration is already enabled for gerrit pre-commit
verification.
I also sneaked in a few other updates on other files to remove them
from the 'muted' list in build-support/iwyu/iwyu-filter.awk
Change-Id: I052056efc32b5173c51cd3f0f939e19e604a7091
Reviewed-on: http://gerrit.cloudera.org:8080/7773
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M build-support/iwyu/iwyu-filter.awk
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
M src/kudu/integration-tests/internal_mini_cluster-itest-base.h
M src/kudu/integration-tests/internal_mini_cluster.cc
M src/kudu/integration-tests/internal_mini_cluster.h
M src/kudu/integration-tests/log_verifier.cc
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/sys_catalog-test.cc
M src/kudu/rpc/connection.h
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_server_test_util.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/net/sockaddr.cc
29 files changed, 38 insertions(+), 37 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I052056efc32b5173c51cd3f0f939e19e604a7091
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [iwyu] a minor clean-up after recent merges
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7773
to look at the new patch set (#2).
Change subject: [iwyu] a minor clean-up after recent merges
......................................................................
[iwyu] a minor clean-up after recent merges
After recent updates, some file became not compliant with IWYU.
This patch fixes that to have the IWYU in the clean state since
the IWYU configuration is already enabled for gerrit pre-commit
verification.
I also sneaked in a few other updates on other files to remove them
from the 'muted' list in build-support/iwyu/iwyu-filter.awk
Change-Id: I052056efc32b5173c51cd3f0f939e19e604a7091
---
M build-support/iwyu/iwyu-filter.awk
M src/kudu/client/master_rpc.cc
M src/kudu/client/master_rpc.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
M src/kudu/integration-tests/internal_mini_cluster-itest-base.h
M src/kudu/integration-tests/internal_mini_cluster.cc
M src/kudu/integration-tests/internal_mini_cluster.h
M src/kudu/integration-tests/log_verifier.cc
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/sys_catalog-test.cc
M src/kudu/rpc/connection.h
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_server_test_util.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/net/sockaddr.cc
29 files changed, 38 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/7773/2
--
To view, visit http://gerrit.cloudera.org:8080/7773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I052056efc32b5173c51cd3f0f939e19e604a7091
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [iwyu] a minor clean-up after recent merges
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [iwyu] a minor clean-up after recent merges
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I052056efc32b5173c51cd3f0f939e19e604a7091
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [iwyu] a minor clean-up after recent merges
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] a minor clean-up after recent merges
......................................................................
Patch Set 2: Verified+1
unrelated flake in delete_table-itest.0
--
To view, visit http://gerrit.cloudera.org:8080/7773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I052056efc32b5173c51cd3f0f939e19e604a7091
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No