[GitHub] [superset] jinghua-qa commented on pull request #17029: fix(other): column name in created content on profile page

[GitBox <gi...@apache.org>]

jinghua-qa commented on pull request #17029:
URL: https://github.com/apache/superset/pull/17029#issuecomment-939024044


   > Hello @jinghua-qa. It's great that you are contributing! There is a problem with this change though. As you can see from your screenshot the date is gone. This is because you need to change the `mutator` function as well, which takes care of populating the date.
   > 
   > Specifically:
   > 
   > https://github.com/apache/superset/blob/a99f845481cd26be56cd0db6b623279db9a27d24/superset-frontend/src/profile/components/CreatedContent.tsx#L55
   > 
   > To be changed with `created`
   > 
   > https://github.com/apache/superset/blob/a99f845481cd26be56cd0db6b623279db9a27d24/superset-frontend/src/profile/components/CreatedContent.tsx#L56
   > 
   > To be changed with `_created`
   > 
   > The same goes for the other `mutator` function in this file.
   
   Thank you for catching that, i make change accordingly~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org