[GitHub] [superset] yousoph commented on a diff in pull request #20566: fix(heatmap): rename 'Normalize Across' to 'Color Based On' and re-label

[GitBox <gi...@apache.org>]

yousoph commented on code in PR #20566:
URL: https://github.com/apache/superset/pull/20566#discussion_r915074293


##########
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx:
##########
@@ -163,17 +164,34 @@ const config: ControlPanelConfig = {
             name: 'normalize_across',
             config: {
               type: 'SelectControl',
-              label: t('Normalize Across'),
+              label: t('Color based on'),
               choices: [
                 ['heatmap', 'heatmap'],
                 ['x', 'x'],
                 ['y', 'y'],
               ],
               default: 'heatmap',
-              description: t(
-                'Color will be rendered based on a ratio ' +
-                  'of the cell against the sum of across this ' +
-                  'criteria',
+              description: (
+                <>
+                  <div>
+                    {t(
+                      'Color will be rendered based on a ratio of the cell against the sum of across this criteria: ',

Review Comment:
   Yes! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org