You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/10 07:45:59 UTC

[GitHub] [camel-k] lucamolteni commented on a diff in pull request #3804: fix(#3800): Add proper kamel CLI to image build on macOS

lucamolteni commented on code in PR #3804:
URL: https://github.com/apache/camel-k/pull/3804#discussion_r1018747831


##########
script/Makefile:
##########
@@ -402,7 +402,11 @@ maven-overlay:
 kamel-overlay:
 	@echo "####### Copying kamel CLI to output build directory..."
 	mkdir -p build/_output/bin
-	cp kamel build/_output/bin
+  ifeq ($(shell uname -m), arm64)

Review Comment:
   The problem appears for both macOS running on `x86_64` and on `arm64` - a macOS compiled library will never work inside a Linux container image.
   
   why not 
   
   `ifneq ($(shell uname -m), Linux)`
   
   ?
   If it's anything else than Linux, put the linux binary inside the image



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org