You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/10/06 20:16:30 UTC
[GitHub] [thrift] belugabehr opened a new pull request #2254: THRIFT-5288: Move Support for ByteBuffer into TTransport
belugabehr opened a new pull request #2254:
URL: https://github.com/apache/thrift/pull/2254
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [X] Did you create an [THRIFT-5288](https://issues.apache.org/jira/browse/THRIFT-5288)
- [X] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [X] Did you squash your changes to a single commit? (not required, but preferred)
- [X] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [X] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2254: THRIFT-5288: Better Support for ByteBuffer in Compact Protocol
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2254:
URL: https://github.com/apache/thrift/pull/2254#issuecomment-703309412
```
make[3]: Entering directory '/thrift/src/lib/java'
./gradlew assemble \
-Prelease=true \
-Pthrift.version=0.14.0 \
--console=plain
> Task :copyDependencies
> Task :compileJava
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:39: warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated
import org.apache.http.params.CoreConnectionPNames;
^
/thrift/src/lib/java/src/org/apache/thrift/transport/TNonblockingTransport.java:52: error: write(ByteBuffer) in TNonblockingTransport cannot override write(ByteBuffer) in TTransport
public abstract int write(ByteBuffer buffer) throws IOException;
^
return type int is not compatible with void
/thrift/src/lib/java/src/org/apache/thrift/transport/TNonblockingSocket.java:170: error: write(ByteBuffer) in TNonblockingSocket cannot override write(ByteBuffer) in TTransport
public int write(ByteBuffer buffer) throws IOException {
^
return type int is not compatible with void
/thrift/src/lib/java/src/org/apache/thrift/meta_data/FieldMetaData.java:61: warning: [deprecation] newInstance() in Class has been deprecated
sClass.newInstance();
^
where T is a type-variable:
T extends Object declared in class Class
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:165: warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated
client.getParams().setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, connectTimeout_);
^
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:165: warning: [deprecation] getParams() in HttpClient has been deprecated
client.getParams().setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, connectTimeout_);
^
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:174: warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated
client.getParams().setParameter(CoreConnectionPNames.SO_TIMEOUT, readTimeout_);
^
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:174: warning: [deprecation] getParams() in HttpClient has been deprecated
client.getParams().setParameter(CoreConnectionPNames.SO_TIMEOUT, readTimeout_);
^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 errors
6 warnings
> Task :compileJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 14s
2 actionable tasks: 2 executed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr closed pull request #2254: THRIFT-5288: Move Support for ByteBuffer into TTransport
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #2254:
URL: https://github.com/apache/thrift/pull/2254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2254: THRIFT-5288: Move Support for ByteBuffer into TTransport
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2254:
URL: https://github.com/apache/thrift/pull/2254#issuecomment-705167718
Right, not your problem. Some Erlang problems that (still) need to be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2254: THRIFT-5288: Move Support for ByteBuffer into TTransport
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2254:
URL: https://github.com/apache/thrift/pull/2254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2254: THRIFT-5288: Better Support for ByteBuffer in Compact Protocol
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2254:
URL: https://github.com/apache/thrift/pull/2254#issuecomment-703955766
Woops. I thought I was adding functionality, but I guess I was actually overwriting. I just made a new push, we'll see what happens, but I am definitely breaking API here by changing method signatures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2254: THRIFT-5288: Better Support for ByteBuffer in Compact Protocol
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2254:
URL: https://github.com/apache/thrift/pull/2254#issuecomment-703309412
make[3]: Entering directory '/thrift/src/lib/java'
./gradlew assemble \
-Prelease=true \
-Pthrift.version=0.14.0 \
--console=plain
> Task :copyDependencies
> Task :compileJava
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:39: warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated
import org.apache.http.params.CoreConnectionPNames;
^
/thrift/src/lib/java/src/org/apache/thrift/transport/TNonblockingTransport.java:52: error: write(ByteBuffer) in TNonblockingTransport cannot override write(ByteBuffer) in TTransport
public abstract int write(ByteBuffer buffer) throws IOException;
^
return type int is not compatible with void
/thrift/src/lib/java/src/org/apache/thrift/transport/TNonblockingSocket.java:170: error: write(ByteBuffer) in TNonblockingSocket cannot override write(ByteBuffer) in TTransport
public int write(ByteBuffer buffer) throws IOException {
^
return type int is not compatible with void
/thrift/src/lib/java/src/org/apache/thrift/meta_data/FieldMetaData.java:61: warning: [deprecation] newInstance() in Class has been deprecated
sClass.newInstance();
^
where T is a type-variable:
T extends Object declared in class Class
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:165: warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated
client.getParams().setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, connectTimeout_);
^
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:165: warning: [deprecation] getParams() in HttpClient has been deprecated
client.getParams().setParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, connectTimeout_);
^
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:174: warning: [deprecation] CoreConnectionPNames in org.apache.http.params has been deprecated
client.getParams().setParameter(CoreConnectionPNames.SO_TIMEOUT, readTimeout_);
^
/thrift/src/lib/java/src/org/apache/thrift/transport/THttpClient.java:174: warning: [deprecation] getParams() in HttpClient has been deprecated
client.getParams().setParameter(CoreConnectionPNames.SO_TIMEOUT, readTimeout_);
^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 errors
6 warnings
> Task :compileJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 14s
2 actionable tasks: 2 executed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] belugabehr commented on pull request #2254: THRIFT-5288: Move Support for ByteBuffer into TTransport
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2254:
URL: https://github.com/apache/thrift/pull/2254#issuecomment-704928055
@Jens-G Hey, can you help me figure out what is causing this build failure? It seems to be to be related to Erlang, but I'm not 100% sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org