You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/02 08:33:54 UTC
[GitHub] [arrow-rs] liukun4515 opened a new issue, #1777: support write page index
liukun4515 opened a new issue, #1777:
URL: https://github.com/apache/arrow-rs/issues/1777
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
From the issue https://github.com/apache/arrow-rs/issues/1705, the feature page index is important for arrow-rs reading and writing.
@Ted-Jiang is working on the reading path for the page index.
I will work on the writing path for page index in the parquet-rs.
@alamb
@tustvold
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #1777: support write page index
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1777:
URL: https://github.com/apache/arrow-rs/issues/1777#issuecomment-1186113094
this issue can't be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #1777: support write page index
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1777:
URL: https://github.com/apache/arrow-rs/issues/1777#issuecomment-1165304884
In the current parquet writer for rust version:
start row group
start a column
write data to the column
end the column and will get the column chunk metadata
end row group
before flush the filemetadata to the disk, we should edit the column chunk metadata and add the index offset and index length metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 closed issue #1777: support write page index
Posted by GitBox <gi...@apache.org>.
liukun4515 closed issue #1777: support write page index
URL: https://github.com/apache/arrow-rs/issues/1777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] nevi-me commented on issue #1777: support write page index
Posted by GitBox <gi...@apache.org>.
nevi-me commented on issue #1777:
URL: https://github.com/apache/arrow-rs/issues/1777#issuecomment-1153271316
> One thing I stumbled across whilst reviewing the read side, is that the ColumnIndex has an implicit assumption that semantic records don't span page boundaries. That is the first repetition level of each page is 0. I think we may need to enforce this when writing file with a column index. https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L920
I think it should be considered a bug if part of a record is recorded over 2 page boundaries. It would create ambiguity on the record, and force a reader to potentially read the page in reverse to find the start of the record. Great catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #1777: support write page index
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1777:
URL: https://github.com/apache/arrow-rs/issues/1777#issuecomment-1161387136
```
* For example:
*
* <pre>
* rows col1 col2 col3
* ┌──────┬──────┬──────┐
* 0 │ p0 │ │ │
* ╞══════╡ p0 │ p0 │
* 20 │ p1(X)│------│------│
* ╞══════╪══════╡ │
* 40 │ p2(X)│ │------│
* ╞══════╡ p1(X)╞══════╡
* 60 │ p3(X)│ │------│
* ╞══════╪══════╡ │
* 80 │ p4 │ │ p1 │
* ╞══════╡ p2 │ │
* 100 │ p5 │ │ │
* └──────┴──────┴──────┘
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #1777: support write page index
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #1777:
URL: https://github.com/apache/arrow-rs/issues/1777#issuecomment-1147686956
One thing I stumbled across whilst reviewing the read side, is that the ColumnIndex has a hard-coded assumption that semantic records don't span page boundaries. That is the first repetition level of each page is 0. I think we may need to enforce this when writing file with a column index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #1777: support write page index
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1777:
URL: https://github.com/apache/arrow-rs/issues/1777#issuecomment-1161331389
@tustvold
I have read the write path in the https://github.com/apache/parquet-mr and am very familiar with the write path of parquet.
Diff column chunk in the same row group may contain diff number of pages.
A value just can be encoded into only one page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #1777: support write page index
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1777:
URL: https://github.com/apache/arrow-rs/issues/1777#issuecomment-1161372136
After go through current write path in the arrow-rs, I think we need to do some minor refactor to collect and write Page Index to the tail of the parquet file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org