You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "NazilaAk (via GitHub)" <gi...@apache.org> on 2025/05/30 21:55:06 UTC

[PR] [R] Ensure that bit64's "new semantics" work with arrow [arrow]

NazilaAk opened a new pull request, #46651:
URL: https://github.com/apache/arrow/pull/46651

   ### Rationale for this change
   Based on the #44208 issue, we want to make sure that we have test for new semantic of bit64
   
   ### What changes are included in this PR?
   New test
   
   ### Are these changes tested?
   NA
   
   ### Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [R] Ensure that bit64's "new semantics" work with arrow [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46651:
URL: https://github.com/apache/arrow/pull/46651#issuecomment-2923587542

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

Posted by "NazilaAk (via GitHub)" <gi...@apache.org>.
NazilaAk commented on code in PR #46651:
URL: https://github.com/apache/arrow/pull/46651#discussion_r2145129042


##########
r/tests/testthat/test-Array.R:
##########
@@ -352,6 +352,20 @@ test_that("array supports integer64", {
   expect_true(as.vector(is.na(all_na)))
 })
 
+test_that("array supports integer64 with new sematics", {
+  options(integer64_semantics="new")

Review Comment:
   Thanks for the suggestion. I updated the diff, hopefully it's ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46651:
URL: https://github.com/apache/arrow/pull/46651#issuecomment-2923591934

   :warning: GitHub issue #44208 **has no components**, please add labels for components.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #46651:
URL: https://github.com/apache/arrow/pull/46651#issuecomment-3021342386

   I'm going to merge this, but am still interested in the answer to this:
   
   > Do you know if any of the semantics changes mean we should add other tests? Or does this cover the new behavior(s) in bit64?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #46651:
URL: https://github.com/apache/arrow/pull/46651#discussion_r2121386114


##########
r/tests/testthat/test-Array.R:
##########
@@ -352,6 +352,20 @@ test_that("array supports integer64", {
   expect_true(as.vector(is.na(all_na)))
 })
 
+test_that("array supports integer64 with new sematics", {
+  options(integer64_semantics="new")

Review Comment:
   Would you mind wrapping this in `withr::with_options(list(integer64_semantics = "new"), {...}`
   
   see https://github.com/apache/arrow/blob/c2fb0e3500ff73662275eeab9e96abc5d3090d82/r/tests/testthat/test-Array.R#L842 for an example. This will ensure the option isn't kept on after.



##########
r/tests/testthat/test-Array.R:
##########
@@ -352,6 +352,20 @@ test_that("array supports integer64", {
   expect_true(as.vector(is.na(all_na)))
 })
 
+test_that("array supports integer64 with new sematics", {
+  options(integer64_semantics="new")
+  x <- bit64::as.integer64(1:10) + MAX_INT 

Review Comment:
   ```suggestion
     x <- bit64::as.integer64(1:10) + MAX_INT
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46651:
URL: https://github.com/apache/arrow/pull/46651#issuecomment-2923591929

   :warning: GitHub issue #44208 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46651:
URL: https://github.com/apache/arrow/pull/46651#issuecomment-3021405338

   How about #46955?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane merged PR #46651:
URL: https://github.com/apache/arrow/pull/46651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46651:
URL: https://github.com/apache/arrow/pull/46651#issuecomment-3021387991

   It seems that this introduced lint errors:
   
   https://github.com/apache/arrow/actions/runs/15987292796/job/45094044698#step:5:18
   
   ```text
   R Lint...................................................................Failed
   - hook id: lintr
   - exit code: 1
   
   Error: Not lint free
   tests/testthat/test-Array.R:355:57: style: [brace_linter] Opening curly braces should never go on their own line and should always be followed by a new line.
   test_that("array supports integer64 with new sematics", {
                                                           ^
   
   tests/testthat/test-Array.R:356:58: style: [brace_linter] Opening curly braces should never go on their own line and should always be followed by a new line.
     withr::with_options(list(integer64_semantics = "new"), {
                                                            ^
   
   Error: estthat/test-Array.R:368:1: error: [error] unexpected '}'
   })
   ^
   Execution halted
   25h
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46651:
URL: https://github.com/apache/arrow/pull/46651#issuecomment-3022178662

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ab4e52e6f15fb61ea4f32504f52270b553a9b0ad.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/45107723165) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org