You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/08/17 01:14:45 UTC
[GitHub] [accumulo] FineAndDandy opened a new pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets
FineAndDandy opened a new pull request #1560:
URL: https://github.com/apache/accumulo/pull/1560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1560:
URL: https://github.com/apache/accumulo/pull/1560#issuecomment-712317408
Closing since this didn't make it into 1.10. It was added to 2.1 in #1614. The only thing left that could be done would be to add the property to the deprecated bulk import code and I wouldn't recommend doing that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #1560:
URL: https://github.com/apache/accumulo/pull/1560#discussion_r427285465
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -549,7 +549,9 @@
TSERV_SLOW_FILEPERMIT_MILLIS("tserver.slow.filepermit.time", "100ms", PropertyType.TIMEDURATION,
"If a thread blocks more than this period of time waiting to get file permits,"
+ " debugging information will be written."),
-
+ TSERV_BULK_MAX_TABLET_OVERLAP("tserver.bulk.max.overlap", "0", PropertyType.COUNT,
Review comment:
I agree, I don't think users care whether the prefix is tserver or master. I don't think its worth going through a deprecation cycle to migrate all of the ```tserver``` properties to ```master``` or ```general```. That just adds extra unnecessary work for users. I think the name ```master.bulk.max.tablets``` is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1560:
URL: https://github.com/apache/accumulo/pull/1560#issuecomment-674609256
PR auto-closed when 1.9 branch was removed. Re-opened and set base branch to 1.10 instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on a change in pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #1560:
URL: https://github.com/apache/accumulo/pull/1560#discussion_r427354245
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -549,7 +549,9 @@
TSERV_SLOW_FILEPERMIT_MILLIS("tserver.slow.filepermit.time", "100ms", PropertyType.TIMEDURATION,
"If a thread blocks more than this period of time waiting to get file permits,"
+ " debugging information will be written."),
-
+ TSERV_BULK_MAX_TABLET_OVERLAP("tserver.bulk.max.overlap", "0", PropertyType.COUNT,
Review comment:
> I think the name master.bulk.max.tablets is OK.
I like that name and would be in favor of using it in 1.9 and 2.x. The name will make more sense in 2.x than in 1.9 but that is better for the long term.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1560:
URL: https://github.com/apache/accumulo/pull/1560#issuecomment-630909029
I am in the process of adding this check to the new bulk import for 2.1. I think this would be useful to have in the old bulk import process as well, but will be different for 2.x since some of the old code was refactored for reuse with the new code. Adding a new check to the deprecated API in 2.x is debatable and back porting this check to 1.9/1.10 is also debatable. I think the maintenance cost of something like this is very minimal and would benefit users who don't want to risk switching to the newer API. The new bulk API should have significant improvements yet may come with some bugs initially as it has yet to be tested in production at a large scale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime closed pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets
Posted by GitBox <gi...@apache.org>.
milleruntime closed pull request #1560:
URL: https://github.com/apache/accumulo/pull/1560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii closed pull request #1560: fixes #1559 - Prevent Bulk loading files that exceed TSERV_BULK_MAX_TABLET_OVERLAP tablets
Posted by GitBox <gi...@apache.org>.
ctubbsii closed pull request #1560:
URL: https://github.com/apache/accumulo/pull/1560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org