You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/13 07:04:22 UTC

[GitHub] [pulsar] leizhiyuan opened a new issue, #15149: autoReadDisabledRateLimiting is not corrent when limiting by pendingSendRequest

leizhiyuan opened a new issue, #15149:
URL: https://github.com/apache/pulsar/issues/15149

   **Describe the bug**
   A clear and concise description of what the bug is.
   
   in ServerCnx
   
   ```
      if (++pendingSendRequest == maxPendingSendRequests || isPublishRateExceeded) {
               // When the quota of pending send requests is reached, stop reading from socket to cause backpressure on
               // client connection, possibly shared between multiple producers
               ctx.channel().config().setAutoRead(false);
               recordRateLimitMetrics(producers);
               autoReadDisabledRateLimiting = isPublishRateExceeded;
               throttledConnections.inc();
           }
   ```
   
   if ++pendingSendRequest == maxPendingSendRequests is true,  but isPublishRateExceeded is false.
   
   autoReadDisabledRateLimiting = isPublishRateExceeded; will be false ,but it should be true
   
   **Expected behavior**
   A clear and concise description of what you expected to happen.
   
   autoReadDisabledRateLimiting = true;
   
   **Screenshots**
   If applicable, add screenshots to help explain your problem.
   
   **Desktop (please complete the following information):**
    - OS: [e.g. iOS]
   
   **Additional context**
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] leizhiyuan closed issue #15149: autoReadDisabledRateLimiting is not corrent when limiting by pendingSendRequest

Posted by GitBox <gi...@apache.org>.
leizhiyuan closed issue #15149: autoReadDisabledRateLimiting is not corrent when limiting by pendingSendRequest
URL: https://github.com/apache/pulsar/issues/15149


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on issue #15149: autoReadDisabledRateLimiting is not corrent when limiting by pendingSendRequest

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15149:
URL: https://github.com/apache/pulsar/issues/15149#issuecomment-1126612623

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org