You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/10/11 22:08:11 UTC
[PR] fix(server): preserve container exit status [hugegraph]
imbajin opened a new pull request, #3311:
URL: https://github.com/apache/hugegraph/pull/3311
## Purpose
The Server container watched a daemon JVM with `tail --pid` and returned 1 whenever it stopped. A normal JVM exit 0 and an application exit 42 therefore looked identical. The entrypoint now owns the existing foreground launcher and returns its status after readiness, including 137 for SIGKILL.
## Changes
- Preserve the existing REST startup deadline and HStore partition check; a JVM that exits normally before readiness still fails startup.
- Keep readiness probes and partition checks interruptible, and terminate/reap their owned processes during shutdown.
- Ignore duplicate group/forwarded signals while the launcher reaps its JVM. TERM and INT request cooperative shutdown and return 143 and 130.
- Document timeout and shutdown behavior, and run the new native-process regression from the existing entrypoint suite.
## Validation
The native lifecycle cases passed, covering normal and failing exits, SIGKILL, direct and process-group signals, early exits, startup deadlines, pending partition checks and real stalled HTTP readiness probes. They also check recorded child processes are gone after cooperative shutdown. The existing configuration, encoding and foreground launcher signal suites passed. Formatting and a clean Java 17 reactor compile passed; three independent reviews and re-review found no remaining actionable issue.
The process tests exercise the actual shell scripts with a small JVM substitute. Real Linux container/OOM and Kubernetes acceptance remain separate follow-up checks. A startup timeout requests termination and returns 1 without adding an indefinite wait; an unresponsive JVM still depends on container termination for final cleanup.
The same org branch passed its selected CI, including startup contracts, Server/RocksDB/HStore and cluster tests, container/deployment checks, platform compatibility and CodeQL.
Org validation: https://github.com/hugegraph/hugegraph/pull/289
## Documentation
Doc - Done: `docker/README.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(server): preserve container exit status [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #3311:
URL: https://github.com/apache/hugegraph/pull/3311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(server): preserve container exit status [hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3311:
URL: https://github.com/apache/hugegraph/pull/3311#issuecomment-6114561958
## [Codecov](https://app.codecov.io/gh/apache/hugegraph/pull/3311?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.91%. Comparing base ([`7644566`](https://app.codecov.io/gh/apache/hugegraph/commit/7644566e58f0a3f9acabfef7ab448714b7afe1f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`56b8f6e`](https://app.codecov.io/gh/apache/hugegraph/commit/56b8f6e7a101c0fcd97151c94a05e9ab33645939?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3311 +/- ##
============================================
- Coverage 52.29% 48.91% -3.38%
+ Complexity 6052 820 -5232
============================================
Files 762 66 -696
Lines 67399 6137 -61262
Branches 9138 658 -8480
============================================
- Hits 35244 3002 -32242
+ Misses 28601 2887 -25714
+ Partials 3554 248 -3306
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph/pull/3311?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org