You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/15 00:30:00 UTC

Re: Review Request 66015: Built CSI spec proto files with CMake.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/
-----------------------------------------------------------

(Updated March 15, 2018, 12:29 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
-------

Fixed the commit message and added `csi.proto` as a byproduct.


Summary (updated)
-----------------

Built CSI spec proto files with CMake.


Bugs: MESOS-8657
    https://issues.apache.org/jira/browse/MESOS-8657


Repository: mesos


Description (updated)
-------

Built CSI spec proto files with CMake.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 
  3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d 
  src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef 


Diff: https://reviews.apache.org/r/66015/diff/3/

Changes: https://reviews.apache.org/r/66015/diff/2-3/


Testing (updated)
-------

`make check` with CMake.


Thanks,

Chun-Hung Hsiao

Re: Review Request 66015: Built CSI spec proto files with CMake.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/#review199233
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On March 14, 2018, 5:29 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66015/
> -----------------------------------------------------------
> 
> (Updated March 14, 2018, 5:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8657
>     https://issues.apache.org/jira/browse/MESOS-8657
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Built CSI spec proto files with CMake.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191 
>   3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d 
>   src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef 
> 
> 
> Diff: https://reviews.apache.org/r/66015/diff/3/
> 
> 
> Testing
> -------
> 
> `make check` with CMake.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>