You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/11/03 18:32:51 UTC
Review Request 27530: HostComponent requests that include Nagios are
not performant
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27530/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Sid Wagle.
Bugs: AMBARI-8118
https://issues.apache.org/jira/browse/AMBARI-8118
Repository: ambari
Description
-------
Removed code that called to nagios_alerts.php directly, since that code is no longer used; even in 1.7.0
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 732203a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpProxyPropertyProvider.java ca2bd52
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HttpPropertyProviderTest.java bf3550f
Diff: https://reviews.apache.org/r/27530/diff/
Testing
-------
manual testing and:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29:30.870s
[INFO] Finished at: Mon Nov 03 12:12:05 EST 2014
[INFO] Final Memory: 29M/213M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 27530: HostComponent requests that include Nagios
are not performant
Posted by Nate Cole <nc...@hortonworks.com>.
> On Nov. 3, 2014, 12:50 p.m., Jonathan Hurley wrote:
> > I assume that the (now deprecated) NagiosPropertyProvider handles this for 1.7.0
Thanks for commenting! Yes, NagiosPropertyProvider was the "replacement" for this functionality.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27530/#review59595
-----------------------------------------------------------
On Nov. 3, 2014, 12:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27530/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 12:32 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
>
>
> Bugs: AMBARI-8118
> https://issues.apache.org/jira/browse/AMBARI-8118
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed code that called to nagios_alerts.php directly, since that code is no longer used; even in 1.7.0
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 732203a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpProxyPropertyProvider.java ca2bd52
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HttpPropertyProviderTest.java bf3550f
>
> Diff: https://reviews.apache.org/r/27530/diff/
>
>
> Testing
> -------
>
> manual testing and:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 29:30.870s
> [INFO] Finished at: Mon Nov 03 12:12:05 EST 2014
> [INFO] Final Memory: 29M/213M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 27530: HostComponent requests that include Nagios
are not performant
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27530/#review59595
-----------------------------------------------------------
Ship it!
I assume that the (now deprecated) NagiosPropertyProvider handles this for 1.7.0
- Jonathan Hurley
On Nov. 3, 2014, 12:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27530/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 12:32 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
>
>
> Bugs: AMBARI-8118
> https://issues.apache.org/jira/browse/AMBARI-8118
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed code that called to nagios_alerts.php directly, since that code is no longer used; even in 1.7.0
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 732203a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpProxyPropertyProvider.java ca2bd52
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HttpPropertyProviderTest.java bf3550f
>
> Diff: https://reviews.apache.org/r/27530/diff/
>
>
> Testing
> -------
>
> manual testing and:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 29:30.870s
> [INFO] Finished at: Mon Nov 03 12:12:05 EST 2014
> [INFO] Final Memory: 29M/213M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>