You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2005/05/31 13:43:48 UTC

DO NOT REPLY [Bug 35134] New: - [shale] DialogNavigationHandler behavior depends on isDebugEnabled

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35134>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35134

           Summary: [shale] DialogNavigationHandler  behavior depends on
                    isDebugEnabled
           Product: Struts
           Version: Nightly Build
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Shale
        AssignedTo: dev@struts.apache.org
        ReportedBy: keijo.nurmes@sysopen.fi


In class org.apache.shale.dialog.faces.DialogNavigationHandler method transition:
transition from a ViewState with null outcome, current state is returned  
only if 'log.isDebugEnabled()' is true.

Suggested patch:

Index:
/shale-trunk/core-library/src/java/org/apache/shale/dialog/faces/DialogNavigationHandler.java
===================================================================
---
/shale-trunk/core-library/src/java/org/apache/shale/dialog/faces/DialogNavigationHandler.java
(revision 170542)
+++
/shale-trunk/core-library/src/java/org/apache/shale/dialog/faces/DialogNavigationHandler.java
(working copy)
@@ -470,8 +470,8 @@
         if ((state instanceof ViewState) && (outcome == null)) {
             if (log.isDebugEnabled()) {
                 log.debug("  --> Stay in current state");
-                return state;
             }
+            return state;
         }
 
         // Identify the appropriate Transition

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org