[GitHub] [rocketmq-connect] zhouxinyu commented on a change in pull request #5: add fc sink task

[GitBox <gi...@apache.org>]

zhouxinyu commented on a change in pull request #5:
URL: https://github.com/apache/rocketmq-connect/pull/5#discussion_r817453656



##########
File path: aliyun/rocketmq-connect-fc/src/main/resources/log4j.properties
##########
@@ -0,0 +1,28 @@
+log4j.rootCategory=INFO, console
+log4j.appender.console=org.apache.log4j.ConsoleAppender
+log4j.appender.console.target=System.err
+log4j.appender.console.layout=org.apache.log4j.PatternLayout
+log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
+
+# Set the default spark-shell log level to WARN. When running the spark-shell, the
+# log level for this class is used to overwrite the root logger's log level, so that

Review comment:
       Why there are spark-related configs?

##########
File path: aliyun/rocketmq-connect-fc/src/test/java/com/aliyun/rocketmq/connect/fc/sink/FcSinkConnectorTest.java
##########
@@ -0,0 +1,14 @@
+package com.aliyun.rocketmq.connect.fc.sink;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class FcSinkConnectorTest {
+
+    private final FcSinkConnector fcSinkConnector = new FcSinkConnector();
+
+    @Test
+    public void testTaskConfigs() {
+        Assert.assertEquals(fcSinkConnector.taskConfigs(1).size(), 1);

Review comment:
       Could you please add more unit tests for the core features?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org