You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2024/08/06 00:34:04 UTC
(impala) branch master updated (0918147e6 -> 5b7ed40d5)
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
from 0918147e6 IMPALA-13270: Fix IllegalStateException on runtime filter
new 7d72a0c17 IMPALA-13271: Correct the documentation with respect to granting privileges on URI
new 5b7ed40d5 IMPALA-13252: Always use PrintId for TUniqueId
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
be/src/runtime/coordinator.cc | 2 +-
be/src/util/debug-util.h | 4 ----
docs/topics/impala_authorization.xml | 13 +++++--------
3 files changed, 6 insertions(+), 13 deletions(-)
(impala) 01/02: IMPALA-13271: Correct the documentation with respect to granting privileges on URI
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 7d72a0c17d0c69b6378496d8839fcce2c7427f1c
Author: m-sanjana19 <ma...@gmail.com>
AuthorDate: Fri Aug 2 12:03:47 2024 +0530
IMPALA-13271: Correct the documentation with respect to granting privileges on URI
Currently, when an administrator grants a privilege on a URI to
a grantee via impala-shell, the created policy in Ranger's policy
repository is non-recursive.
That is, the policy does not apply for any directory under the URI.
This patch corrects this in the documentation.
Change-Id: Ife9f07294fb0f0b24acb1c8d0199c64ec7d73e9a
Reviewed-on: http://gerrit.cloudera.org:8080/21633
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Fang-Yu Rao <fa...@cloudera.com>
---
docs/topics/impala_authorization.xml | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/docs/topics/impala_authorization.xml b/docs/topics/impala_authorization.xml
index d25dfab38..79d9d4742 100644
--- a/docs/topics/impala_authorization.xml
+++ b/docs/topics/impala_authorization.xml
@@ -255,14 +255,11 @@ under the License.
<conbody>
- <p>
- URIs represent the file paths you specify as part of statements such as <codeph>CREATE
- EXTERNAL TABLE</codeph> and <codeph>LOAD DATA</codeph>. Typically, you specify what
- look like UNIX paths, but these locations can also be prefixed with
- <codeph>hdfs://</codeph> to make clear that they are really URIs. To set privileges
- for a URI, specify the name of a directory, and the privilege applies to all the files
- in that directory and any directories underneath it.
- </p>
+ <p> URIs represent the file paths you specify as part of statements such as <codeph>CREATE
+ EXTERNAL TABLE</codeph> and <codeph>LOAD DATA</codeph>. Typically, you specify what look
+ like UNIX paths, but these locations can also be prefixed with <codeph>hdfs://</codeph> to
+ make clear that they are really URIs. To set privileges for a URI, specify the name of a
+ directory, and the privilege applies to all the files in that directory. </p>
<p>
URIs must start with <codeph>hdfs://</codeph>, <codeph>s3a://</codeph>,
(impala) 02/02: IMPALA-13252: Always use PrintId for TUniqueId
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 5b7ed40d52bb63a5dda0f12f83370b0fbcaaca26
Author: Michael Smith <mi...@cloudera.com>
AuthorDate: Fri Aug 2 15:31:06 2024 -0700
IMPALA-13252: Always use PrintId for TUniqueId
Thrift types provide their own overload of operator<<. In GCC, the
overload added in debug-util.h is preferred, but in Clang the first
overload (from Thrift generated code) is preferred. I don't see a good
way to augment the Thrift definition to use PrintId, so this patch
reverts the overload in debug-util.h and uses PrintId explicitly.
Change-Id: Ic536c12ed67d9d473c7ac7f1e05ebc537ff485d4
Reviewed-on: http://gerrit.cloudera.org:8080/21639
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Yida Wu <wy...@gmail.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
---
be/src/runtime/coordinator.cc | 2 +-
be/src/util/debug-util.h | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/be/src/runtime/coordinator.cc b/be/src/runtime/coordinator.cc
index d49887e52..4014ea2bf 100644
--- a/be/src/runtime/coordinator.cc
+++ b/be/src/runtime/coordinator.cc
@@ -1539,7 +1539,7 @@ void Coordinator::UpdateFilter(const UpdateFilterParamsPB& params, RpcContext* c
std::unordered_set<int> target_fragment_idxs;
if (!IsExecuting()) {
LOG(INFO) << "Filter update received for non-executing query with id: "
- << query_id();
+ << PrintId(query_id());
return;
}
auto it = filter_routing_table_->id_to_filter.find(params.filter_id());
diff --git a/be/src/util/debug-util.h b/be/src/util/debug-util.h
index fcec0e7dc..4d7255e45 100644
--- a/be/src/util/debug-util.h
+++ b/be/src/util/debug-util.h
@@ -74,10 +74,6 @@ constexpr int TUniqueIdBufferSize = 33;
void PrintIdCompromised(const TUniqueId& id, char out[TUniqueIdBufferSize],
const char separator = ':');
-inline ostream& operator<<(ostream& os, const TUniqueId& id) {
- return os << PrintId(id);
-}
-
inline ostream& operator<<(ostream& os, const UniqueIdPB& id) {
return os << PrintId(id);
}