You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ouyangshourui <gi...@git.apache.org> on 2016/01/02 04:44:37 UTC
[GitHub] spark pull request: size RollingPolicy shouldRollover loginfo shou...
GitHub user ouyangshourui opened a pull request:
https://github.com/apache/spark/pull/10549
size RollingPolicy shouldRollover loginfo should change to logDebug
https://issues.apache.org/jira/browse/SPARK-12601
when using size RollingPolicythis code cause worker output a large of log .it shoud be changed to logDebug
the code as following:
/** Should rollover if the next set of bytes is going to exceed the size limit */
def shouldRollover(bytesToBeWritten: Long): Boolean = {
logDebug(s"$bytesToBeWritten + $bytesWrittenSinceRollover > $rolloverSizeBytes")
bytesToBeWritten + bytesWrittenSinceRollover > rolloverSizeBytes
}
-->
/** Should rollover if the next set of bytes is going to exceed the size limit */
def shouldRollover(bytesToBeWritten: Long): Boolean = {
logDebug(s"$bytesToBeWritten + $bytesWrittenSinceRollover > $rolloverSizeBytes")
bytesToBeWritten + bytesWrittenSinceRollover > rolloverSizeBytes
}
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ouyangshourui/spark rollingsizeloginfo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10549.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10549
----
commit ec1fc25f12dfd77146be3ad3931fbdcc1ff680eb
Author: ouyangshourui <49...@qq.com>
Date: 2016-01-02T03:41:17Z
size RollingPolicy shouldRollover loginfo should change to logDebug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: size RollingPolicy shouldRollover loginfo shou...
Posted by ouyangshourui <gi...@git.apache.org>.
Github user ouyangshourui commented on the pull request:
https://github.com/apache/spark/pull/10549#issuecomment-168376381
thank you ,srowen .you can close this PR. I will argue this change is necessary in the JIRA in SPARK-12601.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: size RollingPolicy shouldRollover loginfo shou...
Posted by ouyangshourui <gi...@git.apache.org>.
Github user ouyangshourui closed the pull request at:
https://github.com/apache/spark/pull/10549
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: size RollingPolicy shouldRollover loginfo shou...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10549#issuecomment-168361621
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: size RollingPolicy shouldRollover loginfo shou...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10549#issuecomment-168375947
Please read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark Do you mind closing this PR or fixing it? though I think you first need to argue this change is necessary in the JIRA, and that means fixing the JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org