You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2022/07/07 02:32:25 UTC

[GitHub] [celix] PengZheng commented on a diff in pull request #427: Making default no compression

PengZheng commented on code in PR #427:
URL: https://github.com/apache/celix/pull/427#discussion_r915396060


##########
cmake/cmake_celix/BundlePackaging.cmake:
##########
@@ -18,6 +18,9 @@
 
 
 set(CELIX_NO_POSTFIX_BUILD_TYPES RelWithDebInfo Release CACHE STRING "The build type used for creating bundle without a build type postfix.")
+set(CELIX_DEFAULT_JAR_COMMAND_ARGUMENTS -cfm0 CACHE STRING "Default no compression is applied")

Review Comment:
   Just curious why we made that change? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org