You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by netroby <gi...@git.apache.org> on 2017/01/21 03:03:19 UTC
[GitHub] incubator-rocketmq pull request #47: Add link to README.md for RocketMQ home
GitHub user netroby opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/47
Add link to README.md for RocketMQ home
See https://issues.apache.org/jira/browse/ROCKETMQ-69
Signed-off-by: huzhifeng <hu...@douyu.tv>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/netroby/incubator-rocketmq pr/add-link-to-rocketmq-home
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit 7967f8c0eb819b3a24725555c6e53441ac2c13d2
Author: huzhifeng <hu...@douyu.tv>
Date: 2017-01-21T03:02:26Z
Add link to README.md for RocketMQ home
See https://issues.apache.org/jira/browse/ROCKETMQ-69
Signed-off-by: huzhifeng <hu...@douyu.tv>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...
Posted by netroby <gi...@git.apache.org>.
Github user netroby commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/47
@zhouxinyu @vongosling Have a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #47: [ROCKETMQ-69]Add link to README.md for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/47
[](https://coveralls.io/builds/9778619)
Coverage decreased (-0.03%) to 22.606% when pulling **7967f8c0eb819b3a24725555c6e53441ac2c13d2 on netroby:pr/add-link-to-rocketmq-home** into **b997c9743e155df8d330bad54479ac320e722a36 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/47
[](https://coveralls.io/builds/9778675)
Coverage decreased (-0.02%) to 22.615% when pulling **fdad1d30aa6aa9157b594344ea7d94dea2a9494b on netroby:pr/add-link-to-rocketmq-home** into **b997c9743e155df8d330bad54479ac320e722a36 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #47: [ROCKETMQ-69]Add link to README.md for ...
Posted by WillemJiang <gi...@git.apache.org>.
Github user WillemJiang commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/47#discussion_r97189480
--- Diff: README.md ---
@@ -22,6 +22,7 @@ It offers a variety of features as follows:
----------
## Learn it & Contact us
+* Home: [https://rocketmq.apache.org](https://rocketmq.apache.org)
--- End diff --
It could be better to use <> instead of []() , as we don't need to change the display discription here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...
Posted by netroby <gi...@git.apache.org>.
Github user netroby commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/47
I will change code , thanks.
Appreciate your time.
----------------------------
Netroby
2017-01-21 11:24 GMT+08:00 Willem Jiang <no...@github.com>:
> *@WillemJiang* commented on this pull request.
> ------------------------------
>
> In README.md
> <https://github.com/apache/incubator-rocketmq/pull/47#pullrequestreview-17798863>
> :
>
> > @@ -22,6 +22,7 @@ It offers a variety of features as follows:
> ----------
>
> ## Learn it & Contact us
> +* Home: [https://rocketmq.apache.org](https://rocketmq.apache.org)
>
> It could be better to use <> instead of , as we don't need to change the
> display discription here.
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-rocketmq/pull/47#pullrequestreview-17798863>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAQ-iX4wga7RJrIyHEiirehCTg-KUqYiks5rUXp3gaJpZM4Lp8K0>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/47
[](https://coveralls.io/builds/9778682)
Coverage increased (+0.008%) to 22.64% when pulling **532edaa7a38caa1d6e5b266931e032935af88ef1 on netroby:pr/add-link-to-rocketmq-home** into **b997c9743e155df8d330bad54479ac320e722a36 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---