You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/11 22:06:44 UTC
[GitHub] [incubator-hudi] prashantwason opened a new pull request #1399:
[MINOR] Removing code which is duplicated from the base class.
prashantwason opened a new pull request #1399: [MINOR] Removing code which is duplicated from the base class.
URL: https://github.com/apache/incubator-hudi/pull/1399
## What is the purpose of the pull request
Remove some dead code. Improves code coverage.
## Brief change log
Removed code is present in the base class HoodieWriteHandle.
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage. Verified using:
mvn clean package
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1399:
[MINOR] Removing code which is duplicated from the base class.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1399: [MINOR] Removing code which is duplicated from the base class.
URL: https://github.com/apache/incubator-hudi/pull/1399#issuecomment-597925767
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=h1) Report
> Merging [#1399](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/77d5b92d88d6583bdfc09e4c10ecfe7ddbb04806&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1399 +/- ##
============================================
+ Coverage 67.40% 67.49% +0.09%
Complexity 230 230
============================================
Files 336 336
Lines 16366 16351 -15
Branches 1672 1671 -1
============================================
+ Hits 11031 11036 +5
+ Misses 4602 4580 -22
- Partials 733 735 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/hudi/io/HoodieMergeHandle.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vSG9vZGllTWVyZ2VIYW5kbGUuamF2YQ==) | `78.87% <ø> (+6.89%)` | `0.00 <0.00> (ø)` | |
| [...g/apache/hudi/metrics/InMemoryMetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9Jbk1lbW9yeU1ldHJpY3NSZXBvcnRlci5qYXZh) | `25.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
| [...n/java/org/apache/hudi/common/model/HoodieKey.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUtleS5qYXZh) | `88.88% <0.00%> (-5.56%)` | `0.00% <0.00%> (ø%)` | |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `79.79% <0.00%> (-1.02%)` | `8.00% <0.00%> (ø%)` | |
| [...ache/hudi/common/util/collection/DiskBasedMap.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvY29sbGVjdGlvbi9EaXNrQmFzZWRNYXAuamF2YQ==) | `83.07% <0.00%> (+8.46%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=footer). Last update [77d5b92...dc187ca](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1399: [MINOR]
Removing code which is duplicated from the base class.
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1399: [MINOR] Removing code which is duplicated from the base class.
URL: https://github.com/apache/incubator-hudi/pull/1399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io commented on issue #1399: [MINOR]
Removing code which is duplicated from the base class.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1399: [MINOR] Removing code which is duplicated from the base class.
URL: https://github.com/apache/incubator-hudi/pull/1399#issuecomment-597925767
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=h1) Report
> Merging [#1399](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/77d5b92d88d6583bdfc09e4c10ecfe7ddbb04806?src=pr&el=desc) will **decrease** coverage by `66.76%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1399 +/- ##
============================================
- Coverage 67.4% 0.64% -66.77%
+ Complexity 230 2 -228
============================================
Files 336 289 -47
Lines 16366 14360 -2006
Branches 1672 1466 -206
============================================
- Hits 11031 92 -10939
- Misses 4602 14265 +9663
+ Partials 733 3 -730
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/hudi/io/HoodieMergeHandle.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vSG9vZGllTWVyZ2VIYW5kbGUuamF2YQ==) | `0% <ø> (-71.98%)` | `0 <0> (ø)` | |
| [...apache/hudi/common/model/HoodieDeltaWriteStat.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZURlbHRhV3JpdGVTdGF0LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../index/hbase/DefaultHBaseQPSResourceAllocator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvaGJhc2UvRGVmYXVsdEhCYXNlUVBTUmVzb3VyY2VBbGxvY2F0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...org/apache/hudi/common/model/HoodieFileFormat.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUZpbGVGb3JtYXQuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...g/apache/hudi/execution/BulkInsertMapFunction.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhlY3V0aW9uL0J1bGtJbnNlcnRNYXBGdW5jdGlvbi5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../common/util/queue/IteratorBasedQueueProducer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvcXVldWUvSXRlcmF0b3JCYXNlZFF1ZXVlUHJvZHVjZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...rg/apache/hudi/index/bloom/KeyRangeLookupTree.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvYmxvb20vS2V5UmFuZ2VMb29rdXBUcmVlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...e/hudi/common/table/timeline/dto/FileGroupDTO.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL2R0by9GaWxlR3JvdXBEVE8uamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...apache/hudi/timeline/service/handlers/Handler.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvaGFuZGxlcnMvSGFuZGxlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...che/hudi/common/table/timeline/dto/LogFileDTO.java](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL2R0by9Mb2dGaWxlRFRPLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [290 more](https://codecov.io/gh/apache/incubator-hudi/pull/1399/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=footer). Last update [77d5b92...dc187ca](https://codecov.io/gh/apache/incubator-hudi/pull/1399?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1399: [MINOR] Removing code which is duplicated from the base class.
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1399: [MINOR] Removing code which is duplicated from the base class.
URL: https://github.com/apache/incubator-hudi/pull/1399#discussion_r391329711
##########
File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -92,65 +92,11 @@ public static Schema createHoodieWriteSchema(Schema originalSchema) {
return HoodieAvroUtils.addMetadataFields(originalSchema);
Review comment:
this method is also unused?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services