[jira] [Commented] (SLING-8781) use model's bundle context to lookup services

["Nicolas Peltier (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953014#comment-16953014 ] 

Nicolas Peltier commented on SLING-8781:
----------------------------------------

[~pauls] [~justin] [~sseifert]  [~kwin] [~cziegeler] 

did fix it in [https://github.com/apache/sling-org-apache-sling-models-impl/pull/16]

not super elegant, but could not find a better/easier way. As predicted by Karl, this reduces # of CNFE to (almost) 0.

Also i wonder if i should not remove previous change  [0], warned by [1], even though i see it "working" so far.

[0] https://github.com/apache/sling-org-apache-sling-models-impl/commit/f2e948b4c0f338dcebeedce8c09f7d6f283e4183

[1] https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L126

> use model's bundle context to lookup services
> ---------------------------------------------
>
>                 Key: SLING-8781
>                 URL: https://issues.apache.org/jira/browse/SLING-8781
>             Project: Sling
>          Issue Type: Improvement
>          Components: Sling Models
>    Affects Versions: Sling Models Impl 1.4.10
>            Reporter: Nicolas Peltier
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Searching for all the silent ClassNotFoundExceptions generated, as discussed offline with [~kpauls]
> {quote}It seems like the sling models service injector is using its own bundle context for the lookup. That makes this case reasonable problematic. Typically, an extender uses the bundle context of the bundle it extends - which would in this case make the lookup likely not run into any CNFE for the assignable check. If anything, you could try there and see if you could make it use the bundle context of the extended bundle.
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)