[GitHub] [kafka] ijuma commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #10024:
URL: https://github.com/apache/kafka/pull/10024#discussion_r569225393



##########
File path: core/src/test/scala/kafka/common/InterBrokerSendThreadTest.scala
##########
@@ -51,6 +52,26 @@ class InterBrokerSendThreadTest {
         Some(queue.dequeue())
       }
     }
+    override def pollOnce(maxTimeoutMs: Long): Unit = {
+      try super.pollOnce(maxTimeoutMs)
+      catch {
+        case e: Throwable => exceptionCallback(e)
+      }
+    }
+
+  }
+
+  @Test
+  def shutdownThreadShouldNotCauseException(): Unit = {

Review comment:
       I don't think we should have a test inside a non test class. Gradle won't run it for once and it's quite confusing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org