You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "wankunde (via GitHub)" <gi...@apache.org> on 2024/10/10 07:55:18 UTC
[PR] [CELEBORN-1638] Improve the slots allocator performance [celeborn]
wankunde opened a new pull request, #2799:
URL: https://github.com/apache/celeborn/pull/2799
### What changes were proposed in this pull request?
When we try to allocate a large number of slots, the iterator.move of ArrayList partitionIdList will be very slow。
We can use LinkedList instead of ArrayList to optimize slots allocator.
<img width="845" alt="image" src="https://github.com/user-attachments/assets/3053bb1c-830e-44d4-88c5-3cc017e91994">
### Why are the changes needed?
To improve the slot allocator performance
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
We can test this PR with `SlotsAllocatorRackAwareSuiteJ.testRackAwareRoundRobinReplicaDistribution()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1638] Improve the slots allocator performance [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #2799: [CELEBORN-1638] Improve the slots allocator performance
URL: https://github.com/apache/celeborn/pull/2799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1638] Improve the slots allocator performance [celeborn]
Posted by "wankunde (via GitHub)" <gi...@apache.org>.
wankunde commented on PR #2799:
URL: https://github.com/apache/celeborn/pull/2799#issuecomment-2404491211
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org