You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by maropu <gi...@git.apache.org> on 2018/06/16 05:18:49 UTC

[GitHub] spark pull request #21565: [SPARK-24558][Core]wrong Idle Timeout value is us...

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21565#discussion_r195894599
  
    --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -488,9 +488,16 @@ private[spark] class ExecutorAllocationManager(
         newExecutorTotal = numExistingExecutors
         if (testing || executorsRemoved.nonEmpty) {
           executorsRemoved.foreach { removedExecutorId =>
    +        // If it is cachedBlcok timeout is configured using
    +        // spark.dynamicAllocation.cachedExecutorIdleTimeout
    +        val idleTimeout = if (SparkEnv.get.blockManager.master.hasCachedBlocks(removedExecutorId)) {
    --- End diff --
    
    `blockManagerMaster.hasCachedBlocks(removedExecutorId)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org