You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "sullis (via GitHub)" <gi...@apache.org> on 2025/03/27 15:04:17 UTC
[PR] Core: Cleanup TestFindFiles [iceberg]
sullis opened a new pull request, #12666:
URL: https://github.com/apache/iceberg/pull/12666
# Motivation
TestFindFiles declares @Parameters containing format version.
The parent class, TestBase, already provides @Parameters with
the format version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Cleanup TestFindFiles [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #12666:
URL: https://github.com/apache/iceberg/pull/12666#issuecomment-2760381254
There are more subclasses of `TestBase` that define the same parameters as the base class, so it would be good to clean those up as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Cleanup unit tests [iceberg]
Posted by "sullis (via GitHub)" <gi...@apache.org>.
sullis commented on PR #12666:
URL: https://github.com/apache/iceberg/pull/12666#issuecomment-2761846481
I pushed an update to this branch. I identified 34 unit tests that needed cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Cleanup unit tests [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #12666:
URL: https://github.com/apache/iceberg/pull/12666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Cleanup TestFindFiles [iceberg]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on PR #12666:
URL: https://github.com/apache/iceberg/pull/12666#issuecomment-2759934998
TestFindFiles isn't the only class having `1, 2, 3 formatVersion`. For instance, TestCreateTransaction and TestSnapshot also have the same parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org